Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: components/cronet/android/java/src/org/chromium/net/CronetEngine.java

Issue 1389213003: [Cronet] Use Https for Quic Test Server (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ryancl
Patch Set: Address Paul's comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/CronetEngine.java
diff --git a/components/cronet/android/java/src/org/chromium/net/CronetEngine.java b/components/cronet/android/java/src/org/chromium/net/CronetEngine.java
index 2de7e8d001ef96e49d84d07f5305d474fdbcc03e..8ae1d32f966728a5b9dc79b75fe01d8fd46ea822 100644
--- a/components/cronet/android/java/src/org/chromium/net/CronetEngine.java
+++ b/components/cronet/android/java/src/org/chromium/net/CronetEngine.java
@@ -292,6 +292,14 @@ public abstract class CronetEngine {
}
/**
+ * Sets a native MockCertVerifier for testing.
+ */
+ Builder setMockCertVerifierForTesting(long mockCertVerifier) {
+ return putString(
mef 2015/10/19 15:35:21 Is there particular reason not to use putLong?
xunjieli 2015/10/19 15:38:05 putLong doesn't work. The base/json/json_value_con
+ CronetEngineBuilderList.MOCK_CERT_VERIFIER, String.valueOf(mockCertVerifier));
+ }
+
+ /**
* Get JSON string representation of the builder.
*/
@Override

Powered by Google App Engine
This is Rietveld 408576698