[Cronet] Use Https for Quic Test Server

components/cronet/url_request_context_config.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/cronet/url_request_context_config.h"
 
+#include "base/basictypes.h"
 #include "base/json/json_reader.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/strings/string_number_conversions.h"
+#include "base/strings/string_piece.h"
 #include "base/values.h"
+#include "net/cert/cert_verifier.h"
 #include "net/quic/quic_protocol.h"
 #include "net/quic/quic_utils.h"
 #include "net/url_request/url_request_context_builder.h"
 
 namespace cronet {
 
+namespace {
+
+bool GetMockCertVerifierFromString(
+    const base::StringPiece& mock_cert_verifier_string,
+    scoped_ptr<net::CertVerifier>* result) {

[pauljensen, 2015/10/20 13:53:58]

passing pointers to scoped_ptr's is strictly forbade:
  http://dev.chromium.org/developers/smart-pointer-guidelines
but in this case we're kinda forced by the semantics of RegisterCustomField.
I guess I'm okay with this, knowing that we'll remove all this
serializing/deserializing soon.  Perhaps add a TODO with link to
crbug.com/544976

[xunjieli, 2015/10/20 15:23:11]

Done.

+  int64 val;
+  bool success = base::StringToInt64(mock_cert_verifier_string, &val);
+  *result = make_scoped_ptr(reinterpret_cast<net::CertVerifier*>(val));
+  return success;
+}
+
+}  // namespace
+
 #define DEFINE_CONTEXT_CONFIG(x) const char REQUEST_CONTEXT_CONFIG_##x[] = #x;
 #include "components/cronet/url_request_context_config_list.h"
 #undef DEFINE_CONTEXT_CONFIG
 
 URLRequestContextConfig::QuicHint::QuicHint() {
 }
 
 URLRequestContextConfig::QuicHint::~QuicHint() {
 }
 
 // static
 void URLRequestContextConfig::QuicHint::RegisterJSONConverter(
     base::JSONValueConverter<URLRequestContextConfig::QuicHint>* converter) {
   converter->RegisterStringField(REQUEST_CONTEXT_CONFIG_QUIC_HINT_HOST,
                                  &URLRequestContextConfig::QuicHint::host);
   converter->RegisterIntField(
       REQUEST_CONTEXT_CONFIG_QUIC_HINT_PORT,
       &URLRequestContextConfig::QuicHint::port);
   converter->RegisterIntField(
       REQUEST_CONTEXT_CONFIG_QUIC_HINT_ALT_PORT,
       &URLRequestContextConfig::QuicHint::alternate_port);
 }
 
-URLRequestContextConfig::URLRequestContextConfig() {
-}
+URLRequestContextConfig::URLRequestContextConfig()
+    : mock_cert_verifier(nullptr) {}

[pauljensen, 2015/10/20 13:53:58]

unnecessary, remove

[xunjieli, 2015/10/20 15:23:11]

Done.

 
 URLRequestContextConfig::~URLRequestContextConfig() {
 }
 
 bool URLRequestContextConfig::LoadFromJSON(const std::string& config_string) {
   scoped_ptr<base::Value> config_value = base::JSONReader::Read(config_string);
   if (!config_value || !config_value->IsType(base::Value::TYPE_DICTIONARY)) {
     DLOG(ERROR) << "Bad JSON: " << config_string;
     return false;
   }
@@ skipping 22 matching lines @@
     cache_params.max_size = http_cache_max_size;
     context_builder->EnableHttpCache(cache_params);
   } else {
     context_builder->DisableHttpCache();
   }
   context_builder->set_user_agent(user_agent);
   context_builder->SetSpdyAndQuicEnabled(enable_spdy, enable_quic);
   context_builder->set_quic_connection_options(
       net::QuicUtils::ParseQuicConnectionOptions(quic_connection_options));
   context_builder->set_sdch_enabled(enable_sdch);
-
+  if (mock_cert_verifier)
+    context_builder->SetCertVerifier(mock_cert_verifier.Pass());
 }
 
 // static
 void URLRequestContextConfig::RegisterJSONConverter(
     base::JSONValueConverter<URLRequestContextConfig>* converter) {
   converter->RegisterStringField(REQUEST_CONTEXT_CONFIG_USER_AGENT,
                                  &URLRequestContextConfig::user_agent);
   converter->RegisterStringField(REQUEST_CONTEXT_CONFIG_STORAGE_PATH,
                                  &URLRequestContextConfig::storage_path);
   converter->RegisterBoolField(REQUEST_CONTEXT_CONFIG_ENABLE_QUIC,
@@ skipping 18 matching lines @@
       &URLRequestContextConfig::data_reduction_primary_proxy);
   converter->RegisterStringField(
       REQUEST_CONTEXT_CONFIG_DATA_REDUCTION_FALLBACK_PROXY,
       &URLRequestContextConfig::data_reduction_fallback_proxy);
   converter->RegisterStringField(
       REQUEST_CONTEXT_CONFIG_DATA_REDUCTION_SECURE_PROXY_CHECK_URL,
       &URLRequestContextConfig::data_reduction_secure_proxy_check_url);
   converter->RegisterStringField(
       REQUEST_CONTEXT_CONFIG_DATA_REDUCTION_PROXY_KEY,
       &URLRequestContextConfig::data_reduction_proxy_key);
+
+  // For Testing.
+  converter->RegisterCustomField<scoped_ptr<net::CertVerifier>>(
+      REQUEST_CONTEXT_CONFIG_MOCK_CERT_VERIFIER,
+      &URLRequestContextConfig::mock_cert_verifier,
+      &GetMockCertVerifierFromString);
 }
 
 }  // namespace cronet