Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Side by Side Diff: fpdfsdk/src/javascript/JS_Context.cpp

Issue 1389163007: Pass IJS_Runtime, not IJS_Context, to native object constructors. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Merge changes into stub. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/src/javascript/JS_Context.h ('k') | fpdfsdk/src/javascript/JS_Define.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "JS_Context.h" 7 #include "JS_Context.h"
8 8
9 #include "../../include/javascript/IJavaScript.h" 9 #include "../../include/javascript/IJavaScript.h"
10 #include "JS_EventHandler.h" 10 #include "JS_EventHandler.h"
(...skipping 15 matching lines...) Expand all
26 return m_pRuntime->GetReaderDocument(); 26 return m_pRuntime->GetReaderDocument();
27 } 27 }
28 28
29 CPDFDoc_Environment* CJS_Context::GetReaderApp() { 29 CPDFDoc_Environment* CJS_Context::GetReaderApp() {
30 ASSERT(m_pRuntime != NULL); 30 ASSERT(m_pRuntime != NULL);
31 31
32 return m_pRuntime->GetReaderApp(); 32 return m_pRuntime->GetReaderApp();
33 } 33 }
34 34
35 FX_BOOL CJS_Context::RunScript(const CFX_WideString& script, 35 FX_BOOL CJS_Context::RunScript(const CFX_WideString& script,
36 CFX_WideString& info) { 36 CFX_WideString* info) {
37 v8::Isolate::Scope isolate_scope(m_pRuntime->GetIsolate()); 37 v8::Isolate::Scope isolate_scope(m_pRuntime->GetIsolate());
38 v8::HandleScope handle_scope(m_pRuntime->GetIsolate()); 38 v8::HandleScope handle_scope(m_pRuntime->GetIsolate());
39 v8::Local<v8::Context> context = m_pRuntime->NewJSContext(); 39 v8::Local<v8::Context> context = m_pRuntime->NewJSContext();
40 v8::Context::Scope context_scope(context); 40 v8::Context::Scope context_scope(context);
41 41
42 if (m_bBusy) { 42 if (m_bBusy) {
43 info = JSGetStringFromID(this, IDS_STRING_JSBUSY); 43 *info = JSGetStringFromID(this, IDS_STRING_JSBUSY);
44 return FALSE; 44 return FALSE;
45 } 45 }
46 m_bBusy = TRUE; 46 m_bBusy = TRUE;
47 47
48 ASSERT(m_pEventHandler->IsValid()); 48 ASSERT(m_pEventHandler->IsValid());
49 CJS_Runtime::FieldEvent event(m_pEventHandler->TargetName(), 49 CJS_Runtime::FieldEvent event(m_pEventHandler->TargetName(),
50 m_pEventHandler->EventType()); 50 m_pEventHandler->EventType());
51 if (!m_pRuntime->AddEventToSet(event)) { 51 if (!m_pRuntime->AddEventToSet(event)) {
52 info = JSGetStringFromID(this, IDS_STRING_JSEVENT); 52 *info = JSGetStringFromID(this, IDS_STRING_JSEVENT);
53 return FALSE; 53 return FALSE;
54 } 54 }
55 55
56 FXJSErr error = {NULL, NULL, 0}; 56 CFX_WideString sErrorMessage;
57 int nRet = 0; 57 int nRet = 0;
58 if (script.GetLength() > 0) { 58 if (script.GetLength() > 0) {
59 nRet = FXJS_Execute(m_pRuntime->GetIsolate(), this, script.c_str(), 59 nRet = m_pRuntime->Execute(this, script.c_str(), &sErrorMessage);
60 script.GetLength(), &error);
61 } 60 }
62 61
63 if (nRet < 0) { 62 if (nRet < 0) {
64 CFX_WideString sLine; 63 *info += sErrorMessage;
65 sLine.Format(L"[ Line: %05d { %s } ] : %s", error.linnum - 1, error.srcline,
66 error.message);
67 info += sLine;
68 } else { 64 } else {
69 info = JSGetStringFromID(this, IDS_STRING_RUN); 65 *info = JSGetStringFromID(this, IDS_STRING_RUN);
70 } 66 }
71 67
72 m_pRuntime->RemoveEventFromSet(event); 68 m_pRuntime->RemoveEventFromSet(event);
73 m_pEventHandler->Destroy(); 69 m_pEventHandler->Destroy();
74 m_bBusy = FALSE; 70 m_bBusy = FALSE;
75 71
76 return nRet >= 0; 72 return nRet >= 0;
77 } 73 }
78 74
79 void CJS_Context::OnApp_Init() { 75 void CJS_Context::OnApp_Init() {
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
278 } 274 }
279 275
280 void CJS_Context::OnBatchExec(CPDFSDK_Document* pTarget) { 276 void CJS_Context::OnBatchExec(CPDFSDK_Document* pTarget) {
281 m_pEventHandler->OnBatchExec(pTarget); 277 m_pEventHandler->OnBatchExec(pTarget);
282 } 278 }
283 279
284 void CJS_Context::OnMenu_Exec(CPDFSDK_Document* pTarget, 280 void CJS_Context::OnMenu_Exec(CPDFSDK_Document* pTarget,
285 const CFX_WideString& strTargetName) { 281 const CFX_WideString& strTargetName) {
286 m_pEventHandler->OnMenu_Exec(pTarget, strTargetName); 282 m_pEventHandler->OnMenu_Exec(pTarget, strTargetName);
287 } 283 }
OLDNEW
« no previous file with comments | « fpdfsdk/src/javascript/JS_Context.h ('k') | fpdfsdk/src/javascript/JS_Define.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698