Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.h

Issue 1389133002: content: Use type-parameterized tests for GpuMemoryBuffer implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add blankline Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.h
diff --git a/content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.h b/content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.h
index 244d160bb0bd1c00adacb8d1911487cd0ee2c2d1..959976fba77e9775aed0b307b1a28d67f7aca87f 100644
--- a/content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.h
+++ b/content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.h
@@ -5,6 +5,7 @@
#ifndef CONTENT_COMMON_GPU_CLIENT_GPU_MEMORY_BUFFER_IMPL_SURFACE_TEXTURE_H_
#define CONTENT_COMMON_GPU_CLIENT_GPU_MEMORY_BUFFER_IMPL_SURFACE_TEXTURE_H_
+#include "content/common/content_export.h"
#include "content/common/gpu/client/gpu_memory_buffer_impl.h"
struct ANativeWindow;
@@ -12,14 +13,26 @@ struct ANativeWindow;
namespace content {
// Implementation of GPU memory buffer based on SurfaceTextures.
-class GpuMemoryBufferImplSurfaceTexture : public GpuMemoryBufferImpl {
+class CONTENT_EXPORT GpuMemoryBufferImplSurfaceTexture
+ : public GpuMemoryBufferImpl {
public:
- static scoped_ptr<GpuMemoryBufferImpl> CreateFromHandle(
+ ~GpuMemoryBufferImplSurfaceTexture() override;
+
+ static scoped_ptr<GpuMemoryBufferImplSurfaceTexture> CreateFromHandle(
const gfx::GpuMemoryBufferHandle& handle,
const gfx::Size& size,
gfx::BufferFormat format,
+ gfx::BufferUsage usage,
const DestructionCallback& callback);
+ static bool IsConfigurationSupported(gfx::BufferFormat format,
+ gfx::BufferUsage usage);
+
+ static base::Closure AllocateForTesting(const gfx::Size& size,
+ gfx::BufferFormat format,
+ gfx::BufferUsage usage,
+ gfx::GpuMemoryBufferHandle* handle);
+
// Overridden from gfx::GpuMemoryBuffer:
bool Map(void** data) override;
void Unmap() override;
@@ -32,7 +45,6 @@ class GpuMemoryBufferImplSurfaceTexture : public GpuMemoryBufferImpl {
gfx::BufferFormat format,
const DestructionCallback& callback,
ANativeWindow* native_window);
- ~GpuMemoryBufferImplSurfaceTexture() override;
ANativeWindow* native_window_;
size_t stride_;

Powered by Google App Engine
This is Rietveld 408576698