Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h

Issue 1389133002: content: Use type-parameterized tests for GpuMemoryBuffer implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add blankline Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h
diff --git a/content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h b/content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h
index fedeae774ba5650c8a8f37c9b7484000308df404..c3c39b93e1dcb65c8ea0c1d67cd131e592dc8a56 100644
--- a/content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h
+++ b/content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h
@@ -5,16 +5,18 @@
#ifndef CONTENT_COMMON_GPU_CLIENT_GPU_MEMORY_BUFFER_IMPL_SHARED_MEMORY_H_
#define CONTENT_COMMON_GPU_CLIENT_GPU_MEMORY_BUFFER_IMPL_SHARED_MEMORY_H_
+#include "content/common/content_export.h"
#include "content/common/gpu/client/gpu_memory_buffer_impl.h"
namespace content {
// Implementation of GPU memory buffer based on shared memory.
-class GpuMemoryBufferImplSharedMemory : public GpuMemoryBufferImpl {
+class CONTENT_EXPORT GpuMemoryBufferImplSharedMemory
+ : public GpuMemoryBufferImpl {
public:
~GpuMemoryBufferImplSharedMemory() override;
- static scoped_ptr<GpuMemoryBufferImpl> Create(
+ static scoped_ptr<GpuMemoryBufferImplSharedMemory> Create(
gfx::GpuMemoryBufferId id,
const gfx::Size& size,
gfx::BufferFormat format,
@@ -26,17 +28,25 @@ class GpuMemoryBufferImplSharedMemory : public GpuMemoryBufferImpl {
gfx::BufferFormat format,
base::ProcessHandle child_process);
- static scoped_ptr<GpuMemoryBufferImpl> CreateFromHandle(
+ static scoped_ptr<GpuMemoryBufferImplSharedMemory> CreateFromHandle(
const gfx::GpuMemoryBufferHandle& handle,
const gfx::Size& size,
gfx::BufferFormat format,
+ gfx::BufferUsage usage,
const DestructionCallback& callback);
static bool IsFormatSupported(gfx::BufferFormat format);
static bool IsUsageSupported(gfx::BufferUsage usage);
+ static bool IsConfigurationSupported(gfx::BufferFormat format,
+ gfx::BufferUsage usage);
static bool IsSizeValidForFormat(const gfx::Size& size,
gfx::BufferFormat format);
+ static base::Closure AllocateForTesting(const gfx::Size& size,
+ gfx::BufferFormat format,
+ gfx::BufferUsage usage,
+ gfx::GpuMemoryBufferHandle* handle);
+
// Overridden from gfx::GpuMemoryBuffer:
bool Map(void** data) override;
void Unmap() override;

Powered by Google App Engine
This is Rietveld 408576698