content: Use type-parameterized tests for GpuMemoryBuffer implementations.

content/common/gpu/gpu_memory_buffer_factory_io_surface.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/gpu_memory_buffer_factory_io_surface.h"
 
 #include <CoreFoundation/CoreFoundation.h>
 
 #include <vector>
 
@@ skipping 65 matching lines @@
     case gfx::BufferFormat::BGRX_8888:
     case gfx::BufferFormat::YUV_420:
       NOTREACHED();
       return 0;
   }
 
   NOTREACHED();
   return 0;
 }
 
-const GpuMemoryBufferFactory::Configuration kSupportedConfigurations[] = {
-    {gfx::BufferFormat::BGRA_8888, gfx::BufferUsage::SCANOUT},
-    {gfx::BufferFormat::R_8, gfx::BufferUsage::PERSISTENT_MAP},
-    {gfx::BufferFormat::R_8, gfx::BufferUsage::MAP},
-    {gfx::BufferFormat::BGRA_8888, gfx::BufferUsage::PERSISTENT_MAP},
-    {gfx::BufferFormat::BGRA_8888, gfx::BufferUsage::MAP},
-    {gfx::BufferFormat::UYVY_422, gfx::BufferUsage::MAP},
-    {gfx::BufferFormat::UYVY_422, gfx::BufferUsage::PERSISTENT_MAP},
-    {gfx::BufferFormat::YUV_420_BIPLANAR, gfx::BufferUsage::MAP},
-    {gfx::BufferFormat::YUV_420_BIPLANAR, gfx::BufferUsage::PERSISTENT_MAP},
-};
-
 }  // namespace
 
 GpuMemoryBufferFactoryIOSurface::GpuMemoryBufferFactoryIOSurface() {
 }
 
 GpuMemoryBufferFactoryIOSurface::~GpuMemoryBufferFactoryIOSurface() {
 }
 
 // static
 bool GpuMemoryBufferFactoryIOSurface::IsGpuMemoryBufferConfigurationSupported(
     gfx::BufferFormat format,
     gfx::BufferUsage usage) {
-  for (auto& configuration : kSupportedConfigurations) {
-    if (configuration.format == format && configuration.usage == usage)
-      return true;
+  switch (usage) {
+    case gfx::BufferUsage::SCANOUT:
+      return format == gfx::BufferFormat::BGRA_8888;
+    case gfx::BufferUsage::MAP:
+    case gfx::BufferUsage::PERSISTENT_MAP:
+      return format == gfx::BufferFormat::R_8 ||
+             format == gfx::BufferFormat::BGRA_8888 ||
+             format == gfx::BufferFormat::UYVY_422 ||
+             format == gfx::BufferFormat::YUV_420_BIPLANAR;
   }
-
+  NOTREACHED();
   return false;
 }
 
-void GpuMemoryBufferFactoryIOSurface::GetSupportedGpuMemoryBufferConfigurations(
-    std::vector<Configuration>* configurations) {
-  configurations->assign(
-      kSupportedConfigurations,
-      kSupportedConfigurations + arraysize(kSupportedConfigurations));
-}
-
-gfx::GpuMemoryBufferHandle
-GpuMemoryBufferFactoryIOSurface::CreateGpuMemoryBuffer(
-    gfx::GpuMemoryBufferId id,
+// static
+IOSurfaceRef GpuMemoryBufferFactoryIOSurface::CreateIOSurface(
     const gfx::Size& size,
-    gfx::BufferFormat format,
-    gfx::BufferUsage usage,
-    int client_id,
-    gfx::PluginWindowHandle surface_handle) {
+    gfx::BufferFormat format) {
   size_t num_planes = gfx::NumberOfPlanesForBufferFormat(format);
   base::ScopedCFTypeRef<CFMutableArrayRef> planes(CFArrayCreateMutable(
       kCFAllocatorDefault, num_planes, &kCFTypeArrayCallBacks));
 
   for (size_t plane = 0; plane < num_planes; ++plane) {
     size_t factor = gfx::SubsamplingFactorForBufferFormat(format, plane);
 
     base::ScopedCFTypeRef<CFMutableDictionaryRef> plane_info(
         CFDictionaryCreateMutable(kCFAllocatorDefault, 0,
                                   &kCFTypeDictionaryKeyCallBacks,
                                   &kCFTypeDictionaryValueCallBacks));
     AddIntegerValue(plane_info, kIOSurfacePlaneWidth, size.width() / factor);
     AddIntegerValue(plane_info, kIOSurfacePlaneHeight, size.height() / factor);
     AddIntegerValue(plane_info, kIOSurfacePlaneBytesPerElement,
                     BytesPerElement(format, plane));
 
     CFArrayAppendValue(planes, plane_info);
   }
 
   base::ScopedCFTypeRef<CFMutableDictionaryRef> properties(
       CFDictionaryCreateMutable(kCFAllocatorDefault, 0,
                                 &kCFTypeDictionaryKeyCallBacks,
                                 &kCFTypeDictionaryValueCallBacks));
   AddIntegerValue(properties, kIOSurfaceWidth, size.width());
   AddIntegerValue(properties, kIOSurfaceHeight, size.height());
   AddIntegerValue(properties, kIOSurfacePixelFormat, PixelFormat(format));
   CFDictionaryAddValue(properties, kIOSurfacePlaneInfo, planes);
 
-  base::ScopedCFTypeRef<IOSurfaceRef> io_surface(IOSurfaceCreate(properties));
+  return IOSurfaceCreate(properties);
+}
+
+gfx::GpuMemoryBufferHandle
+GpuMemoryBufferFactoryIOSurface::CreateGpuMemoryBuffer(
+    gfx::GpuMemoryBufferId id,
+    const gfx::Size& size,
+    gfx::BufferFormat format,
+    gfx::BufferUsage usage,
+    int client_id,
+    gfx::PluginWindowHandle surface_handle) {
+  base::ScopedCFTypeRef<IOSurfaceRef> io_surface(CreateIOSurface(size, format));
   if (!io_surface)
     return gfx::GpuMemoryBufferHandle();
 
   if (!IOSurfaceManager::GetInstance()->RegisterIOSurface(id, client_id,
                                                           io_surface)) {
     return gfx::GpuMemoryBufferHandle();
   }
 
   {
     base::AutoLock lock(io_surfaces_lock_);
@@ skipping 44 matching lines @@
 
   scoped_refptr<gfx::GLImageIOSurface> image(
       new gfx::GLImageIOSurface(handle.id, size, internalformat));
   if (!image->Initialize(it->second.get(), format))
     return scoped_refptr<gfx::GLImage>();
 
   return image;
 }
 
 }  // namespace content