content: Use type-parameterized tests for GpuMemoryBuffer implementations.

ui/ozone/platform/drm/common/client_native_pixmap_factory_gbm.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/ozone/platform/drm/common/client_native_pixmap_factory_gbm.h"
 
 #include "ui/gfx/native_pixmap_handle_ozone.h"
 #include "ui/ozone/public/client_native_pixmap_factory.h"
 
 #if defined(USE_VGEM_MAP)
@@ skipping 26 matching lines @@
 
   // ClientNativePixmapFactory:
   void Initialize(base::ScopedFD device_fd) override {
 #if defined(USE_VGEM_MAP)
     // It's called in IO thread. We rely on clients for thread-safety.
     // Switching to an IPC message filter ensures thread-safety.
     DCHECK_LT(vgem_fd_.get(), 0);
     vgem_fd_ = device_fd.Pass();
 #endif
   }
-  std::vector<Configuration> GetSupportedConfigurations() const override {
-    const Configuration kConfigurations[] = {
-        {gfx::BufferFormat::BGRA_8888, gfx::BufferUsage::SCANOUT},
-        {gfx::BufferFormat::BGRX_8888, gfx::BufferUsage::SCANOUT}};
-    std::vector<Configuration> configurations(
-        kConfigurations, kConfigurations + arraysize(kConfigurations));
+  bool IsConfigurationSupported(gfx::BufferFormat format,
+                                gfx::BufferUsage usage) const override {
+    switch (usage) {
+      case gfx::BufferUsage::SCANOUT: {
+        const gfx::BufferFormat kSupportedFormats[] = {
+            gfx::BufferFormat::BGRA_8888, gfx::BufferFormat::BGRX_8888};
+        for (auto& supported_format : kSupportedFormats) {
+          if (supported_format == format)
+            return true;
+        }
+        return false;

[piman, 2015/10/07 01:20:17]

nit: return format == gfx::BufferFormat::BGRA_8888 || format ==
gfx::BufferFormat::BGRX_8888;

That seems simpler and no less maintainable.

[reveman, 2015/10/07 09:05:01]

Done here and in places where I had a similar pattern.

+      }
+      case gfx::BufferUsage::MAP:
+      case gfx::BufferUsage::PERSISTENT_MAP: {
 #if defined(USE_VGEM_MAP)
-    if (vgem_fd_.is_valid()) {
-      configurations.push_back(
-          {gfx::BufferFormat::BGRA_8888, gfx::BufferUsage::MAP});
-      configurations.push_back(
-          {gfx::BufferFormat::BGRA_8888, gfx::BufferUsage::PERSISTENT_MAP});
+        if (vgem_fd_.is_valid()) {
+          const gfx::BufferFormat kSupportedFormat =
+              gfx::BufferFormat::BGRA_8888;
+          if (format == kSupportedFormat)
+            return true;
+        }
+#endif
+        return false;
+      }
     }
-#endif
-    return configurations;
+    NOTREACHED();
+    return false;
   }
   scoped_ptr<ClientNativePixmap> ImportFromHandle(
       const gfx::NativePixmapHandle& handle,
       const gfx::Size& size,
       gfx::BufferUsage usage) override {
     base::ScopedFD scoped_fd(handle.fd.fd);
 
     switch (usage) {
       case gfx::BufferUsage::MAP:
       case gfx::BufferUsage::PERSISTENT_MAP:
@@ skipping 20 matching lines @@
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(ClientNativePixmapFactoryGbm);
 };
 
 ClientNativePixmapFactory* CreateClientNativePixmapFactoryGbm() {
   return new ClientNativePixmapFactoryGbm();
 }
 
 }  // namespace ui