Issue 138913021: Avoid discarding freshly created background tabs

Issue 138913021: Avoid discarding freshly created background tabs (Closed)

Created:
6 years, 10 months ago by James Cook

Modified:
6 years, 10 months ago

Reviewers:
brettw, sky

CC:
chromium-reviews, vsevik, nkostylev+watch_chromium.org, jam, yurys, joi+watch-content_chromium.org, jochen+watch_chromium.org, paulirish+reviews_chromium.org, darin-cc_chromium.org, pfeldman, oshima+watch_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, stevenjb+watch_chromium.org, android-webview-reviews_chromium.org, davemoore+watch_chromium.org, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Avoid discarding freshly created background tabs The Chrome OS out-of-memory tab discarder uses the "last selected" time as a signal for which tab to discard. This starts at 0 for freshly created background tabs, like those created with a control-click. The user probably doesn't want to discard those tabs, since they just opened them. Since the only other user of WebContents::GetLastSelectedTime() is devtools, which uses it for a similar kind of sorting based on activity, rename the method to GetLastActiveTime() and start the value with the tab creation time. BUG=338735 TEST=content_unittests WebContentsImpl.GetLastActiveTime TBR=torne@chromium.org for rename touching android_webview Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251154

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase (last_selected) #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -20 lines)			Patch
M	android_webview/native/aw_dev_tools_server.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/android/dev_tools_server.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/memory/oom_priority_manager.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/memory/oom_priority_manager.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/memory/oom_priority_manager_unittest.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/devtools/devtools_target_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/web_contents/web_contents_impl.h	View	1 2	3 chunks	+5 lines, -3 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	1 2	3 chunks	+4 lines, -3 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl_unittest.cc	View	1 2	1 chunk	+15 lines, -0 lines	0 comments	Download
M	content/public/browser/web_contents.h	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	content/shell/browser/shell_devtools_delegate.cc	View		1 chunk	+1 line, -1 line	0 comments	Download