Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 138913011: Code refactor(rename email to user_id in wallpaper_manager.h/cc) (Closed)

Created:
6 years, 10 months ago by bshe
Modified:
6 years, 10 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Code refactor(rename email to user_id in wallpaper_manager.*) BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251078

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : format nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -102 lines) Patch
M chrome/browser/chromeos/login/wallpaper_manager.h View 1 9 chunks +29 lines, -29 lines 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager.cc View 1 2 22 chunks +76 lines, -73 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bshe
Hi Nikita. This is just a simple code refactor (rename email to user_id as you ...
6 years, 10 months ago (2014-02-10 22:13:57 UTC) #1
Nikita (slow)
lgtm https://codereview.chromium.org/138913011/diff/1/chrome/browser/chromeos/login/wallpaper_manager.cc File chrome/browser/chromeos/login/wallpaper_manager.cc (right): https://codereview.chromium.org/138913011/diff/1/chrome/browser/chromeos/login/wallpaper_manager.cc#newcode1143 chrome/browser/chromeos/login/wallpaper_manager.cc:1143: MoveCustomWallpaperDirectory(kThumbnailWallpaperSubDir, user_id, nit: One parameter per line.
6 years, 10 months ago (2014-02-11 12:25:28 UTC) #2
bshe
done. used git cl format to fix other format nits. Thanks! https://codereview.chromium.org/138913011/diff/1/chrome/browser/chromeos/login/wallpaper_manager.cc File chrome/browser/chromeos/login/wallpaper_manager.cc (right): ...
6 years, 10 months ago (2014-02-13 15:34:04 UTC) #3
bshe
The CQ bit was checked by bshe@chromium.org
6 years, 10 months ago (2014-02-13 15:34:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bshe@chromium.org/138913011/80001
6 years, 10 months ago (2014-02-13 15:34:51 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 17:58:08 UTC) #6
Message was sent while issue was closed. 
Change committed as 251078

Powered by Google App Engine
This is Rietveld 408576698