Issue 138913007: Move RenderBlock::checkForPaginationLogicalHeightChange method to proper parent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 138913007: Move RenderBlock::checkForPaginationLogicalHeightChange method to proper parent (Closed)

Created:
6 years, 11 months ago by atreat

Modified:
6 years, 11 months ago

Reviewers:
leviw_travelin_and_unemployed, eseidel, esprehn, Inactive, ZZZDONOTUSEMEZZZ

CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, leviw_travelin_and_unemployed

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Move RenderBlock::checkForPaginationLogicalHeightChange method to proper parent Move RenderBlock::checkForPaginationLogicalHeightChange method to proper parent RenderBlockFlow. This method is only called by RenderBlockFlow on an instance of itself or its subclass RenderMultiColumnBlock. BUG=302024 R=esprehn, ch.dumez@samsung.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165887

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -34 lines)			Patch
M	Source/core/rendering/RenderBlock.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/rendering/RenderBlock.cpp	View	1 chunk	+0 lines, -32 lines	0 comments	Download
M	Source/core/rendering/RenderBlockFlow.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/rendering/RenderBlockFlow.cpp	View	1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

atreat

On 2014/01/20 21:16:21, atreat wrote: > Please have a look. This is a minor nit, ...

6 years, 11 months ago (2014-01-27 20:17:53 UTC) #2

leviw_travelin_and_unemployed

LGTM. You could tie this to bug 302024

6 years, 11 months ago (2014-01-27 20:28:30 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/138913007/1

6 years, 11 months ago (2014-01-27 21:07:28 UTC) #5

Message was sent while issue was closed.

Change committed as 165887

Expand Messages | Collapse Messages