file_manager: Make test.util.fakeKeyDown more flexible

chrome/browser/resources/file_manager/js/test_util.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Namespace for test related things.
  */
 var test = test || {};
 
 /**
@@ skipping 119 matching lines @@
  * Fakes pressing the down arrow until the given |filename| is selected.
  *
  * @param {Window} contentWindow Window to be tested.
  * @param {string} filename Name of the file to be selected.
  * @return {boolean} True if file got selected, false otherwise.
  */
 test.util.selectFile = function(contentWindow, filename) {
   var table = contentWindow.document.querySelector('#detail-table');
   var rows = table.querySelectorAll('li');
   for (var index = 0; index < rows.length; ++index) {
-    test.util.fakeKeyDown(contentWindow, 'Down', false);
+    test.util.fakeKeyDown(contentWindow, '#file-list', 'Down', false);
     var selection = test.util.getSelectedFiles(contentWindow);
     if (selection.length === 1 && selection[0] === filename)
       return true;
   }
   console.error('Failed to select file "' + filename + '"');
   return false;
 };
 
 /**
- * Sends a fake key event with the given |keyIdentifier| and optional |ctrl|
- * modifier to the file manager.
+ * Sends an event to the element specified by |targetQuery|.
  *
  * @param {Window} contentWindow Window to be tested.
+ * @param {string} targetQuery Query to specify the element.
+ * @param {Event} event Event to be sent.
+ * @return {boolean} True if the event is sent to the target, false otherwise.
+ */
+test.util.sendEvent = function(contentWindow, targetQuery, event) {
+  var target = contentWindow.document.querySelector(targetQuery);
+  if (target) {
+    target.dispatchEvent(event);
+    return true;
+  } else {
+    console.error('Target element for ' + targetQuery + ' not found.');
+    return false;
+  }
+};
+
+/**
+ * Sends a fake key event to the element specified by |targetQuery| with the
+ * given |keyIdentifier| and optional |ctrl| modifier to the file manager.
+ *
+ * @param {Window} contentWindow Window to be tested.
+ * @param {string} targetQuery Query to specify the element.
  * @param {string} keyIdentifier Identifier of the emulated key.
  * @param {boolean} ctrl Whether CTRL should be pressed, or not.
+ * @return {boolean} True if the event is sent to the target, false otherwise.
  */
-test.util.fakeKeyDown = function(contentWindow, keyIdentifier, ctrl) {
+test.util.fakeKeyDown = function(
+    contentWindow, targetQuery, keyIdentifier, ctrl) {
   var event = new KeyboardEvent(
       'keydown',
       { bubbles: true, keyIdentifier: keyIdentifier, ctrlKey: ctrl });
-  var detailTable = contentWindow.document.querySelector('#detail-table');
-  detailTable.querySelector('list').dispatchEvent(event);
+  return test.util.sendEvent(contentWindow, targetQuery, event);
 };
 
 /**
  * Sends a fake mouse click event to the element specified by |targetQuery|.
  *
  * @param {Window} contentWindow Window to be tested.
  * @param {string} targetQuery Query to specify the element.
- * @return {boolean} True if file got selected, false otherwise.
+ * @return {boolean} True if the event is sent to the target, false otherwise.
  */
 test.util.fakeMouseClick = function(contentWindow, targetQuery) {
   var event = new MouseEvent('click', { bubbles: true });
-  var target = contentWindow.document.querySelector(targetQuery);
-  if (target) {
-    target.dispatchEvent(event);
-    return true;
-  } else {
-    console.error('Target element for ' + targetQuery + ' not found.');
-    return false;
-  }
+  return test.util.sendEvent(contentWindow, targetQuery, event);
 };
 
 /**
  * Selects |filename| and fakes pressing Ctrl+C, Ctrl+V (copy, paste).
  *
  * @param {Window} contentWindow Window to be tested.
  * @param {string} filename Name of the file to be copied.
  * @return {boolean} True if copying got simulated successfully. It does not
  *     say if the file got copied, or not.
  */
 test.util.copyFile = function(contentWindow, filename) {
   if (!test.util.selectFile(contentWindow, filename))
     return false;
-  test.util.fakeKeyDown(contentWindow, 'U+0043', true);  // Ctrl+C
-  test.util.fakeKeyDown(contentWindow, 'U+0056', true);  // Ctrl+V
+  // Ctrl+C and Ctrl+V
+  test.util.fakeKeyDown(contentWindow, '#file-list', 'U+0043', true);
+  test.util.fakeKeyDown(contentWindow, '#file-list', 'U+0056', true);
   return true;
 };
 
 /**
  * Selects |filename| and fakes pressing the Delete key.
  *
  * @param {Window} contentWindow Window to be tested.
  * @param {string} filename Name of the file to be deleted.
  * @return {boolean} True if deleting got simulated successfully. It does not
  *     say if the file got deleted, or not.
  */
 test.util.deleteFile = function(contentWindow, filename) {
   if (!test.util.selectFile(contentWindow, filename))
     return false;
-  test.util.fakeKeyDown(contentWindow, 'U+007F', false);  // Delete
+  // Delete
+  test.util.fakeKeyDown(contentWindow, '#file-list', 'U+007F', false);
   return true;
 };
 
 /**
  * Registers message listener, which runs test utility functions.
  */
 test.util.registerRemoteTestUtils = function() {
   var onMessage = chrome.runtime ? chrome.runtime.onMessageExternal :
       chrome.extension.onMessageExternal;
   onMessage.addListener(function(request, sender, sendResponse) {
@@ skipping 31 matching lines @@
           test.util.waitForFileListChange(
               contentWindow, request.args[0], sendResponse);
           return true;
         case 'waitAndAcceptDialog':
           test.util.waitAndAcceptDialog(contentWindow, sendResponse);
           return true;
         case 'selectFile':
           test.util.sendResponse(selectFile(contentWindow, request.args[0]));
           return false;
         case 'fakeKeyDown':
-          test.util.fakeKeyDown(
-              contentWindow, request.args[0], request.request[1]);
+          sendResponse(test.util.fakeKeyDown(contentWindow,
+                                             request.args[0],
+                                             request.args[1],
+                                             request.args[2]));
           return false;
         case 'fakeMouseClick':
           sendResponse(test.util.fakeMouseClick(
               contentWindow, request.args[0]));
           return false;
         case 'copyFile':
           sendResponse(test.util.copyFile(contentWindow, request.args[0]));
           return false;
         case 'deleteFile':
           sendResponse(test.util.deleteFile(contentWindow, request.args[0]));
           return false;
         default:
           console.error('Window function ' + request.func + ' not found.');
       }
     }
     return false;
   });
 };
 
 // Register the test utils.
 test.util.registerRemoteTestUtils();