Issue 13891013: file_manager: Make test.util.fakeKeyDown more flexible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13891013: file_manager: Make test.util.fakeKeyDown more flexible (Closed)

Created:
7 years, 8 months ago by satorux1

Modified:
7 years, 8 months ago

Reviewers:
mtomasz

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

file_manager: Make test.util.fakeKeyDown more flexible Previously, the target element (the file list) was hard coded. Instead, we should be able to specify the target element. BUG=none TEST=none; just a test util change. the existing tests should pass as before Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194735

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -20 lines)			Patch
	M	chrome/browser/resources/file_manager/js/file_manager.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/resources/file_manager/js/test_util.js	View		6 chunks	+38 lines, -20 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

satorux1

7 years, 8 months ago (2013-04-18 00:20:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r194735 (presubmit successful).

Expand Messages | Collapse Messages