Issue 13891011: Better support for chrome for cros local builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13891011: Better support for chrome for cros local builds. (Closed)

Created:
7 years, 8 months ago by achuithb

Modified:
7 years, 8 months ago

Reviewers:
tonyg

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Better support for chrome for cros local builds. * Use ldd to detect chrome for cros local builds. * Add browser types debug-cros and release-cros for chrome for cros on linux. * Remove browser option --cros-desktop BUG=229692 TEST=run_tests works with cros-debug going through the login flow. NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194522

Patch Set 1 #

Patch Set 2 : use subprocess.communicate #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -11 lines)			Patch
M	tools/telemetry/telemetry/core/browser_options.py	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	tools/telemetry/telemetry/core/chrome/desktop_browser_backend.py	View		4 chunks	+5 lines, -3 lines	0 comments	Download
M	tools/telemetry/telemetry/core/chrome/desktop_browser_finder.py	View	1	2 chunks	+26 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

achuithb

Tony: Could you please review this one line fix for the python 2.6 issue (subprocess.check_output ...

7 years, 8 months ago (2013-04-17 02:06:59 UTC) #1

achuithb

Just to confirm - there are no trybots for telemetry yet, right?

7 years, 8 months ago (2013-04-17 02:07:45 UTC) #2

tonyg

On 2013/04/17 02:07:45, achuith.bhandarkar wrote: > Just to confirm - there are no trybots for ...

7 years, 8 months ago (2013-04-17 02:29:48 UTC) #3

achuithb

7 years, 8 months ago (2013-04-17 02:47:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r194522 (presubmit successful).

Expand Messages | Collapse Messages