Issue 13891009: FileSystem mods: Remove some dead snapshot creation code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13891009: FileSystem mods: Remove some dead snapshot creation code. (Closed)

Created:
7 years, 8 months ago by michaeln

Modified:
7 years, 8 months ago

Reviewers:
kinuko

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, kinuko+watch, darin-cc_chromium.org, tzik+watch_chromium.org, ericu

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

FileSystem mods: Remove some dead snapshot creation code. This CL is the 4th in a series of changes that straddle webkit vs chromium repositories. 1) WK: Declare new virtual createSnapshotFile/didCreateSnapshotFile public api methods. 2) CR: Implement the new create method such that the didCreate method is invoked in response. 3) WK: Use the new create method and implement the new didCreate method. 4) CR: Cleanup the obsolete/deprecated blocks of code. BUG=174200 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194648

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -206 lines)			Patch
M	content/browser/fileapi/fileapi_message_filter.h	View	2 chunks	+0 lines, -17 lines	0 comments	Download
M	content/browser/fileapi/fileapi_message_filter.cc	View	3 chunks	+0 lines, -102 lines	0 comments	Download
M	content/common/fileapi/file_system_dispatcher.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	content/common/fileapi/file_system_dispatcher.cc	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	content/common/fileapi/file_system_messages.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	content/common/fileapi/webfilesystem_impl.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	content/common/fileapi/webfilesystem_impl.cc	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	webkit/tools/test_shell/simple_file_system.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	webkit/tools/test_shell/simple_file_system.cc	View	3 chunks	+0 lines, -38 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r194648.

Expand Messages | Collapse Messages