Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1389083002: Revert "Revert of factories should return baseclass, allowing the impl to specialize (patchset #4 i… (Closed)

Created:
5 years, 2 months ago by reed1
Modified:
5 years, 2 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert "Revert of factories should return baseclass, allowing the impl to specialize (patchset #4 id:60001 of https://codereview.chromium.org/1390523005/ )" This reverts commit 95376a0dde3cdf414eb97a20cef3af19ed7e0151. BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/5ea95df02de9cd774d0b84d1341599bbd9c0d8db

Patch Set 1 #

Patch Set 2 : add SK_API to common base-class #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -125 lines) Patch
M bench/MorphologyBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bigtileimagefilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/filterfastbounds.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M gm/pictureimagefilter.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M include/effects/SkBlurImageFilter.h View 2 chunks +11 lines, -15 lines 0 comments Download
M include/effects/SkDropShadowImageFilter.h View 2 chunks +10 lines, -10 lines 0 comments Download
M include/effects/SkMergeImageFilter.h View 2 chunks +13 lines, -13 lines 0 comments Download
M include/effects/SkMorphologyImageFilter.h View 1 5 chunks +8 lines, -8 lines 0 comments Download
M include/effects/SkOffsetImageFilter.h View 1 chunk +10 lines, -8 lines 0 comments Download
M include/effects/SkPictureImageFilter.h View 6 chunks +11 lines, -9 lines 0 comments Download
M include/effects/SkPixelXorXfermode.h View 1 chunk +3 lines, -4 lines 0 comments Download
M include/effects/SkRectShaderImageFilter.h View 1 chunk +7 lines, -6 lines 0 comments Download
M include/effects/SkTableMaskFilter.h View 2 chunks +9 lines, -9 lines 0 comments Download
M include/effects/SkTestImageFilters.h View 2 chunks +6 lines, -6 lines 0 comments Download
M include/effects/SkTileImageFilter.h View 2 chunks +6 lines, -7 lines 0 comments Download
M src/effects/SkRectShaderImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkTileImageFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/ImageFilterTest.cpp View 3 chunks +8 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1389083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1389083002/20001
5 years, 2 months ago (2015-10-06 20:58:48 UTC) #2
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 21:05:39 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5ea95df02de9cd774d0b84d1341599bbd9c0d8db

Powered by Google App Engine
This is Rietveld 408576698