LayoutTests/scrollbars/viewport-scrollbar-corner-with-percent-padding-crash.html - Issue 138903031: Don't let RenderScrollbarPart have padding.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/scrollbars/viewport-scrollbar-corner-with-percent-padding-crash.html

Issue 138903031: Don't let RenderScrollbarPart have padding. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code review - add test. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/scrollbars/viewport-scrollbar-corner-with-percent-padding-crash-expected.txt » ('j') | Source/core/rendering/RenderScrollbarPart.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>Viewport scrollbar corner with percent padding and background ima ge</title>
	Julien - ping for review 2014/02/19 16:25:14 I would prefer having this dumped into the output I would prefer having this dumped into the output as: - it isn't a burden on the test output - it doesn't give us much to put the information into the <title> (you need to open the test case in a browser / content_shell to see that) mstensho (USE GERRIT) 2014/02/22 20:54:50 Done. Show quoted text On 2014/02/19 16:25:14, Julien Chaffraix - PST wrote: > I would prefer having this dumped into the output as: > - it isn't a burden on the test output > - it doesn't give us much to put the information into the <title> (you need to > open the test case in a browser / content_shell to see that) Done.
	5 <script>

	6 if (window.testRunner)

	7 testRunner.dumpAsText();

	8 </script>

	9 <style>

	10 html { overflow: scroll; }

	11 ::-webkit-scrollbar-corner {

	12 padding-right: 85%;

	13 background: bottom repeat-x scroll url(#tCF0) linen;

	14 }

	15 </style>

	16 </head>

	17 <body>

	18 Test for <a href="http://code.google.com/p/chromium/issues/detail?id=341 004">bug 341004</a>:

	19 This test passes if there is no crash when scrollbar's style changes.

	20 </body>

	21 </html>
	Julien - ping for review 2014/02/19 16:25:14 The test doesn't crash for me on Chromium Mac (it The test doesn't crash for me on Chromium Mac (it seems like the scrollbars are not allocated). mstensho (USE GERRIT) 2014/02/22 20:54:50 I don't know. Maybe Mac does things differently wr Show quoted text On 2014/02/19 16:25:14, Julien Chaffraix - PST wrote: > The test doesn't crash for me on Chromium Mac (it seems like the scrollbars are > not allocated). I don't know. Maybe Mac does things differently wrt. scrollbars. It crashes here on Linux, at least.
OLD	NEW