Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 138903021: Strip IDS_ as well as IDR_ in the chrome_messages_json generator. (Closed)

Created:
6 years, 11 months ago by Lambros
Modified:
6 years, 11 months ago
Reviewers:
Sergey Ulanov, Jói
CC:
grit-developer_googlegroups.com
Visibility:
Public.

Description

Strip IDS_ as well as IDR_ in the chrome_messages_json generator. This is needed for renaming string resources in Chrome Remote Desktop webapp from IDR_ to IDS_ for consistency with other Chrome string resources. R=sergeyu@chromium.org Committed: https://code.google.com/p/grit-i18n/source/detail?r=148

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M grit/format/chrome_messages_json.py View 1 chunk +1 line, -1 line 0 comments Download
M grit/format/chrome_messages_json_unittest.py View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lambros
Please could you take a look?
6 years, 11 months ago (2014-01-23 03:03:34 UTC) #1
Sergey Ulanov
lgtm
6 years, 11 months ago (2014-01-23 03:18:06 UTC) #2
Sergey Ulanov
Committed patchset #1 manually as r148 (presubmit successful).
6 years, 11 months ago (2014-01-23 03:22:32 UTC) #3
Sergey Ulanov
6 years, 11 months ago (2014-01-23 03:23:09 UTC) #4
Message was sent while issue was closed.
Landed in r148: https://code.google.com/p/grit-i18n/source/detail?r=148

Powered by Google App Engine
This is Rietveld 408576698