Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 138903007: Fixes _NET_ACTIVE_WINDOW support check in order to not always return no. (Closed)

Created:
6 years, 11 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 11 months ago
Reviewers:
Elliot Glaysher, sadrul
CC:
chromium-reviews, tfarina, ben+views_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@aura_deactivate
Visibility:
Public.

Description

Fixes _NET_ACTIVE_WINDOW support check in order to not always return no. The check is currently not working on Unity because it expects an array of atoms instead of one XID. With this patch, Unity is correctly seen as supporting the feature. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246270 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246520

Patch Set 1 #

Patch Set 2 #

Patch Set 3 : fix views_unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -16 lines) Patch
M ui/views/widget/desktop_aura/desktop_screen_x11_unittest.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_handler.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_handler.cc View 1 2 chunks +9 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
mlamouri (slow - plz ping)
6 years, 11 months ago (2014-01-21 06:38:03 UTC) #1
mlamouri (slow - plz ping)
Oups, I was a bit too fast to send that, I removed important bits in ...
6 years, 11 months ago (2014-01-21 06:46:42 UTC) #2
Elliot Glaysher
lgtm
6 years, 11 months ago (2014-01-21 19:02:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/138903007/40001
6 years, 11 months ago (2014-01-21 22:55:19 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=192971
6 years, 11 months ago (2014-01-22 01:03:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/138903007/40001
6 years, 11 months ago (2014-01-22 04:06:42 UTC) #6
commit-bot: I haz the power
Change committed as 246270
6 years, 11 months ago (2014-01-22 10:23:41 UTC) #7
Mattias Nissler (ping if slow)
A revert of this CL has been created in https://codereview.chromium.org/144003015/ by mnissler@chromium.org. The reason for ...
6 years, 11 months ago (2014-01-22 13:12:22 UTC) #8
mlamouri (slow - plz ping)
sadrul@, could you have a look at the change that I made in order to ...
6 years, 11 months ago (2014-01-22 23:53:42 UTC) #9
sadrul
LGTM It might be useful to have a WaitUntilActive(Window) function that spins up a nested ...
6 years, 11 months ago (2014-01-23 00:04:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/138903007/350001
6 years, 11 months ago (2014-01-23 00:07:43 UTC) #11
commit-bot: I haz the power
6 years, 11 months ago (2014-01-23 04:13:55 UTC) #12
Message was sent while issue was closed.
Change committed as 246520

Powered by Google App Engine
This is Rietveld 408576698