Issue 13890017: dbus:Add FakeImageBurnerClient FakeSystemClockClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13890017: dbus:Add FakeImageBurnerClient FakeSystemClockClient (Closed)

Created:
7 years, 8 months ago by Haruki Sato

Modified:
7 years, 8 months ago

Reviewers:
satorux1

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

dbus:Add FakeImageBurnerClient FakeSystemClockClient These fake classes do nothing for now. We can implement fake behaviors when necessary. BUG=234458, 234499 TEST=trybots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196674

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+147 lines, -39 lines)			Patch
M	chromeos/chromeos.gyp	View	1 2	2 chunks	+8 lines, -0 lines	0 comments	Download
A	chromeos/dbus/fake_image_burner_client.h	View		1 chunk	+35 lines, -0 lines	0 comments	Download
A	chromeos/dbus/fake_image_burner_client.cc	View		1 chunk	+28 lines, -0 lines	0 comments	Download
A	chromeos/dbus/fake_system_clock_client.h	View		1 chunk	+29 lines, -0 lines	0 comments	Download
A	chromeos/dbus/fake_system_clock_client.cc	View		1 chunk	+25 lines, -0 lines	0 comments	Download
M	chromeos/dbus/image_burner_client.cc	View	1	3 chunks	+2 lines, -18 lines	0 comments	Download
M	chromeos/dbus/mock_dbus_thread_manager_without_gmock.h	View	1	3 chunks	+12 lines, -0 lines	0 comments	Download
M	chromeos/dbus/mock_dbus_thread_manager_without_gmock.cc	View	1	4 chunks	+6 lines, -4 lines	0 comments	Download
M	chromeos/dbus/system_clock_client.cc	View	1	3 chunks	+2 lines, -17 lines	0 comments	Download

Total messages: 5 (0 generated)

satorux1

do stubs of these do something? otherwise, you might want to replace stubs with the ...

7 years, 8 months ago (2013-04-26 04:39:26 UTC) #2

Haruki Sato

On 2013/04/26 04:39:26, satorux1 wrote: > do stubs of these do something? otherwise, you might ...

7 years, 8 months ago (2013-04-26 06:34:53 UTC) #3

Haruki Sato

7 years, 8 months ago (2013-04-26 08:20:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r196674 (presubmit successful).