Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1667)

Unified Diff: content/renderer/media/rtc_video_decoder_factory.h

Issue 13890012: Integrate VDA with WebRTC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Create new VDA thread, copy gpu_factories, and add DestructionObserver Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/rtc_video_decoder_factory.h
diff --git a/content/renderer/media/rtc_video_decoder_factory.h b/content/renderer/media/rtc_video_decoder_factory.h
new file mode 100644
index 0000000000000000000000000000000000000000..443b511fcbc357e0aace512abf196346dbb6b9b3
--- /dev/null
+++ b/content/renderer/media/rtc_video_decoder_factory.h
@@ -0,0 +1,43 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_RENDERER_MEDIA_RTC_VIDEO_DECODER_FACTORY_H_
+#define CONTENT_RENDERER_MEDIA_RTC_VIDEO_DECODER_FACTORY_H_
+
+#include "base/message_loop_proxy.h"
+#include "base/threading/thread.h"
+#include "content/common/content_export.h"
+#include "third_party/libjingle/source/talk/media/webrtc/webrtcvideodecoderfactory.h"
+
+namespace webrtc {
+class VideoDecoder;
+}
+
+namespace content {
+class RendererGpuVideoDecoderFactories;
+
+class CONTENT_EXPORT RTCVideoDecoderFactory
Ami GONE FROM CHROMIUM 2013/06/11 23:48:05 Add a TODO to merge with RTCVideoDecoderFactoryTv
wuchengli 2013/06/13 10:28:07 Ditto.
+ : NON_EXPORTED_BASE(public cricket::WebRtcVideoDecoderFactory) {
Ami GONE FROM CHROMIUM 2013/06/11 23:48:05 nit: colon goes on previous line (unlike in webkit
wuchengli 2013/06/13 10:28:07 Ditto. It goes on previous line if the parent clas
+ public:
+ RTCVideoDecoderFactory(
Ami GONE FROM CHROMIUM 2013/06/11 23:48:05 Doco ownership transfer of |vda_thread|.
wuchengli 2013/06/13 10:28:07 Changed the argument type to scoped_ptr<base::Thre
+ const scoped_refptr<RendererGpuVideoDecoderFactories>& gpu_factories,
+ base::Thread* vda_thread);
+
+ // Runs on Chrome_libJingle_WorkerThread and blocks child thread.
Ami GONE FROM CHROMIUM 2013/06/11 23:48:05 here and below do you mean "blocks until child thr
wuchengli 2013/06/13 10:28:07 I meant the child thread blocks on this completing
+ virtual webrtc::VideoDecoder* CreateVideoDecoder(
+ webrtc::VideoCodecType type) OVERRIDE;
+
+ // Runs on Chrome_libJingle_WorkerThread and blocks child thread.
+ virtual void DestroyVideoDecoder(webrtc::VideoDecoder* decoder) OVERRIDE;
+
+ private:
+ scoped_refptr<RendererGpuVideoDecoderFactories> gpu_factories_;
+ scoped_ptr<base::Thread> vda_thread_;
+
+ DISALLOW_COPY_AND_ASSIGN(RTCVideoDecoderFactory);
+};
+
+} // namespace content
+
+#endif // CONTENT_RENDERER_MEDIA_RTC_VIDEO_DECODER_FACTORY_H_

Powered by Google App Engine
This is Rietveld 408576698