Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Unified Diff: content/renderer/media/rtc_video_decoder_factory.cc

Issue 13890012: Integrate VDA with WebRTC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Create new VDA thread, copy gpu_factories, and add DestructionObserver Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/rtc_video_decoder_factory.cc
diff --git a/content/renderer/media/rtc_video_decoder_factory.cc b/content/renderer/media/rtc_video_decoder_factory.cc
new file mode 100644
index 0000000000000000000000000000000000000000..0b0fd5ea70743e449f5c1c359b9c0c661b869de2
--- /dev/null
+++ b/content/renderer/media/rtc_video_decoder_factory.cc
@@ -0,0 +1,38 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/renderer/media/rtc_video_decoder_factory.h"
+
+#include "base/location.h"
+#include "base/memory/scoped_ptr.h"
+#include "content/renderer/media/renderer_gpu_video_decoder_factories.h"
+#include "content/renderer/media/rtc_video_decoder.h"
+
+namespace content {
+
+RTCVideoDecoderFactory::RTCVideoDecoderFactory(
+ const scoped_refptr<RendererGpuVideoDecoderFactories>& gpu_factories,
+ base::Thread* vda_thread)
+ : gpu_factories_(gpu_factories),
+ vda_thread_(vda_thread) {
+}
+
+webrtc::VideoDecoder* RTCVideoDecoderFactory::CreateVideoDecoder(
+ webrtc::VideoCodecType type) {
+ // RendererGpuVideoDecoderFactories is not thread-safe. Make a copy.
+ scoped_ptr<RTCVideoDecoder> decoder(
+ new RTCVideoDecoder(gpu_factories_->Copy()));
wuchengli 2013/06/10 15:24:22 This is a little bit ugly. But I think this is the
+ vda_thread_->message_loop()->AddDestructionObserver(decoder.get());
Ami GONE FROM CHROMIUM 2013/06/11 23:48:05 I think .get() is no longer needed.
Ami GONE FROM CHROMIUM 2013/06/11 23:48:05 Is vda_thread_->message_loop() != gpu_factories_->
wuchengli 2013/06/13 10:28:07 No. We need MessageLoop, not MessageLoopProxy. Onl
wuchengli 2013/06/13 10:28:07 Done. AddDestructionObserver is moved to ctor of R
+ if (decoder->Initialize(type))
+ return decoder.release();
+ // Initialize will fail when the codec is not supported.
+ return NULL;
+}
+
+void RTCVideoDecoderFactory::DestroyVideoDecoder(
+ webrtc::VideoDecoder* decoder) {
+ gpu_factories_->GetMessageLoop()->DeleteSoon(FROM_HERE, decoder);
+}
+
+} // namespace content

Powered by Google App Engine
This is Rietveld 408576698