Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: content/common/gpu/media/exynos_video_decode_accelerator.h

Issue 13890012: Integrate VDA with WebRTC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Create new VDA thread, copy gpu_factories, and add DestructionObserver Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/media/exynos_video_decode_accelerator.h
diff --git a/content/common/gpu/media/exynos_video_decode_accelerator.h b/content/common/gpu/media/exynos_video_decode_accelerator.h
index 0eb3299c018e4465313ed35c00a55994dc80e053..2c817a5803156f30ff4c83fa596598768652c6ce 100644
--- a/content/common/gpu/media/exynos_video_decode_accelerator.h
+++ b/content/common/gpu/media/exynos_video_decode_accelerator.h
@@ -85,12 +85,12 @@ class CONTENT_EXPORT ExynosVideoDecodeAccelerator :
private:
// These are rather subjectively tuned.
enum {
- kMfcInputBufferCount = 8,
+ kMfcInputBufferCount = 12,
wuchengli 2013/06/10 12:33:43 Increasing the buffer counts has much better decod
Ami GONE FROM CHROMIUM 2013/06/11 23:48:05 These numbers are arbitrary (as l.86 says) so no n
kMfcInputBufferMaxSize = 512 * 1024,
- kGscInputBufferCount = 4,
+ kGscInputBufferCount = 8,
// Number of output buffers to use for each VDA stage above what's required
// by the decoder (e.g. DPB size, in H264).
- kDpbOutputBufferExtraCount = 3,
+ kDpbOutputBufferExtraCount = 8,
Pawel Osciak 2013/06/12 23:38:22 This adds almost 42MB to our memory footprint for
sheu 2013/06/13 01:24:26 I can give you two buffers for free by removing kG
wuchengli 2013/06/13 10:28:07 That's great. Will you do it? Or should I remove i
// We're continuing to have issues with synchronization between Mali 3D and
// Exynos video decode, so we buffer this many extra GSC output buffers in
// the GSC free output buffers queue, to add a safety margin.

Powered by Google App Engine
This is Rietveld 408576698