Integrate VDA with WebRTC.

content/renderer/render_thread_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_thread_impl.h"
 
 #include <algorithm>
 #include <limits>
 #include <map>
 #include <vector>
@@ skipping 50 matching lines @@
 #include "content/renderer/gpu/gpu_benchmarking_extension.h"
 #include "content/renderer/gpu/input_event_filter.h"
 #include "content/renderer/gpu/input_handler_manager.h"
 #include "content/renderer/media/audio_input_message_filter.h"
 #include "content/renderer/media/audio_message_filter.h"
 #include "content/renderer/media/audio_renderer_mixer_manager.h"
 #include "content/renderer/media/media_stream_center.h"
 #include "content/renderer/media/media_stream_dependency_factory.h"
 #include "content/renderer/media/midi_message_filter.h"
 #include "content/renderer/media/peer_connection_tracker.h"
+#include "content/renderer/media/renderer_gpu_video_decoder_factories.h"
 #include "content/renderer/media/video_capture_impl_manager.h"
 #include "content/renderer/media/video_capture_message_filter.h"
 #include "content/renderer/memory_benchmarking_extension.h"
 #include "content/renderer/p2p/socket_dispatcher.h"
 #include "content/renderer/plugin_channel_host.h"
 #include "content/renderer/render_process_impl.h"
 #include "content/renderer/render_process_visibility_manager.h"
 #include "content/renderer/render_view_impl.h"
 #include "content/renderer/renderer_webkitplatformsupport_impl.h"
 #include "content/renderer/skia_benchmarking_extension.h"
@@ skipping 782 matching lines @@
 bool RenderThreadImpl::ResolveProxy(const GURL& url, std::string* proxy_list) {
   bool result = false;
   Send(new ViewHostMsg_ResolveProxy(url, &result, proxy_list));
   return result;
 }
 
 void RenderThreadImpl::PostponeIdleNotification() {
   idle_notifications_to_skip_ = 2;
 }
 
+scoped_refptr<media::GpuVideoDecoder::Factories>
+RenderThreadImpl::GetGpuFactories() {

[piman, 2013/07/08 20:53:39]

nit: can you add a DCHECK(IsMainThread());

[wuchengli, 2013/07/09 07:39:19]

Done.

+  const CommandLine* cmd_line = CommandLine::ForCurrentProcess();
+  scoped_refptr<media::GpuVideoDecoder::Factories> gpu_factories;
+  WebGraphicsContext3DCommandBufferImpl* context3d = NULL;
+  if (!cmd_line->HasSwitch(switches::kDisableAcceleratedVideoDecode))
+    context3d = RenderThreadImpl::current()->GetGpuVDAContext3D();

[piman, 2013/07/08 20:53:39]

nit: RenderThreadImpl::current() == this.

[wuchengli, 2013/07/09 07:39:19]

Done.

+  if (context3d) {
+    scoped_refptr<base::MessageLoopProxy> factories_loop =
+        RenderThreadImpl::current()->compositor_message_loop_proxy();
+    if (!factories_loop.get())
+      factories_loop = base::MessageLoopProxy::current();
+    GpuChannelHost* gpu_channel_host =
+        RenderThreadImpl::current()->EstablishGpuChannelSync(

[piman, 2013/07/08 20:53:39]

nit: RenderThreadImpl::current() == this.

[wuchengli, 2013/07/09 07:39:19]

Done.

+            CAUSE_FOR_GPU_LAUNCH_VIDEODECODEACCELERATOR_INITIALIZE);

[piman, 2013/07/08 20:53:39]

note: this can fail in theory (return NULL).
Actually, instead of EstablishGpuChannelSync, you can directly take
gpu_channel_. It may still be NULL if the context was lost.

[wuchengli, 2013/07/09 07:39:19]

I added NULL check. I don't see why gpu_channel_ can be directly used.
EstablishGpuChannelSync may have not been called.

[piman, 2013/07/09 19:35:22]

It has to have been called it you have a non-NULL context3d, since you need the
GpuChannelHost to create it.

[wuchengli, 2013/07/09 22:29:26]

I see. EstablishGpuChannelSync recreates the channel if it has been lost. Do we
want to keep this behavior? If not, GetGpuChannel() can be used because it
checks if the channel is lost.

+    gpu_factories = new RendererGpuVideoDecoderFactories(
+        gpu_channel_host, factories_loop, context3d);
+  }
+  return gpu_factories;
+}
+
 /* static */
 void RenderThreadImpl::OnGpuVDAContextLoss() {
   RenderThreadImpl* self = RenderThreadImpl::current();
   DCHECK(self);
   if (!self->gpu_vda_context3d_)
     return;
   if (self->compositor_message_loop_proxy().get()) {
     self->compositor_message_loop_proxy()
         ->DeleteSoon(FROM_HERE, self->gpu_vda_context3d_.release());
   } else {
@@ skipping 363 matching lines @@
 
 void RenderThreadImpl::SetFlingCurveParameters(
     const std::vector<float>& new_touchpad,
     const std::vector<float>& new_touchscreen) {
   webkit_platform_support_->SetFlingCurveParameters(new_touchpad,
                                                     new_touchscreen);
 
 }
 
 }  // namespace content