Integrate VDA with WebRTC.

content/renderer/media/rtc_video_decoder.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/renderer/media/rtc_video_decoder.h"
+
+#include "base/bind.h"
+#include "base/callback_helpers.h"
+#include "base/logging.h"
+#include "base/memory/ref_counted.h"
+#include "base/message_loop_proxy.h"
+#include "base/task_runner_util.h"
+#include "content/renderer/media/native_handle_impl.h"
+#include "media/base/bind_to_loop.h"
+#include "third_party/webrtc/system_wrappers/interface/ref_count.h"
+
+namespace content {
+
+RTCVideoDecoder::RTCVideoDecoder(
+    const scoped_refptr<media::GpuVideoDecoder::Factories>& factories)
+    : decoder_waiter_(false, false),
+      aborted_waiter_(true, false),
+      frame_width_(0),
+      frame_height_(0),

[Ami GONE FROM CHROMIUM, 2013/06/11 23:48:05]

nit: prefer gfx::Size to individual width/height members.

[wuchengli, 2013/06/13 10:28:07]

Done.

+      state_(kUninitialized),
+      decode_complete_callback_(NULL),
+      weak_factory_(this),
+      factories_(factories),
+      vda_loop_proxy_(factories->GetMessageLoop()),
+      decoder_texture_target_(0),
+      next_picture_buffer_id_(0),
+      next_bitstream_buffer_id_(0) {
+}
+
+RTCVideoDecoder::~RTCVideoDecoder() {
+  DCHECK(vda_loop_proxy_->BelongsToCurrentThread());
+  DCHECK(!vda_.get());  // Release should have been already called.

[Pawel Osciak, 2013/06/12 23:38:22]

.get() shouldn't be required anymore after
http://src.chromium.org/viewvc/chrome?revision=174057&view=revision

[wuchengli, 2013/06/13 10:28:07]

Done.

+  DVLOG(2) << "~RTCVideoDecoder";
+  // Delete all shared memories.
+  for (size_t i = 0; i < available_shm_segments_.size(); ++i) {
+    available_shm_segments_[i]->shm->Close();
+    delete available_shm_segments_[i];
+  }
+  available_shm_segments_.clear();
+  for (std::map<int32, SHMBuffer*>::iterator it =
+           bitstream_buffers_in_decoder_.begin();

[Pawel Osciak, 2013/06/12 23:38:22]

This looks like invalid indent.

[wuchengli, 2013/06/13 10:28:07]

This should be correct. It indents 4 spaces for the subsequent line. I used git
cl format to check this.

[Ami GONE FROM CHROMIUM, 2013/06/13 20:10:03]

Yes this is correct.

+       it != bitstream_buffers_in_decoder_.end(); ++it) {
+    it->second->shm->Close();
+    delete it->second;
+  }
+  bitstream_buffers_in_decoder_.clear();
+  for (std::deque<std::pair<SHMBuffer*, BufferData> >::iterator it =
+           buffers_to_be_decoded.begin();

[Pawel Osciak, 2013/06/12 23:38:22]

Ditto.

[wuchengli, 2013/06/13 10:28:07]

Same above.

+       it != buffers_to_be_decoded.end(); ++it) {
+    it->first->shm->Close();
+    delete it->first;
+  }
+  buffers_to_be_decoded.clear();
+
+  DestroyTextures();

[Ami GONE FROM CHROMIUM, 2013/06/11 23:48:05]

l.37 implies DestroyVDA() was already called which should have already called
DestroyTextures(), no?

[wuchengli, 2013/06/13 10:28:07]

Removed.

+
+  MessageLoop::current()->RemoveDestructionObserver(this);
+}
+
+bool RTCVideoDecoder::Initialize(webrtc::VideoCodecType type) {
+  DCHECK(!vda_loop_proxy_->BelongsToCurrentThread());
+  // Convert WebRTC codec type to media codec profile.
+  media::VideoCodecProfile profile;
+  switch (type) {
+    case webrtc::kVideoCodecVP8:
+      profile = media::VP8PROFILE_MAIN;
+      break;
+    default:
+      DVLOG(2) << "Video codec not supported:" << type;
+      return false;
+  }
+  vda_loop_proxy_->PostTask(
+      FROM_HERE,
+      base::Bind(&RTCVideoDecoder::CreateVideoDecodeAccelerator,

[Ami GONE FROM CHROMIUM, 2013/06/11 23:48:05]

Isn't this exactly what RGVDF::CreateVideoDecodeAccelerator() does?

(AFAICT RVD::Initialize is called on a libjingle thread, trampolines to a
dedicated thread, calls RGVDF::CVDA on the same thread it passed its ctor, so
goes through the new synchronous codepath and returns directly to RVD::CVDA,
which then unblocks the Wait() two lines down; but why not simply call
RGVDF::CVDA here and have it do the trampolining itself?)

[wuchengli, 2013/06/13 10:28:07]

Done. I wanted to initialize a weak pointer in CreateVideoDecodeAccelerator.
It's moved to InitWeakPtr. The code is simpler now.

+                 base::Unretained(this), profile));
+  Wait();
+  return (vda_ != NULL);
+}
+
+int32_t RTCVideoDecoder::InitDecode(
+    const webrtc::VideoCodec* codecSettings,
+    int32_t /*numberOfCores*/) {
+  DVLOG(2) << "InitDecode";
+  DCHECK_EQ(codecSettings->codecType, webrtc::kVideoCodecVP8);
+  if (codecSettings->codecSpecific.VP8.feedbackModeOn) {
+    LOG(ERROR) << "Feedback mode not supported";
+    return WEBRTC_VIDEO_CODEC_ERROR;
+  }
+
+  base::AutoLock auto_lock(lock_);
+  if (state_ == kUninitialized) {
+    LOG(ERROR) << "VDA is not initialized.";
+    return WEBRTC_VIDEO_CODEC_UNINITIALIZED;
+  }
+  return WEBRTC_VIDEO_CODEC_OK;
+}
+
+int32_t RTCVideoDecoder::Decode(
+    const webrtc::EncodedImage& inputImage,
+    bool missingFrames,
+    const webrtc::RTPFragmentationHeader* /*fragmentation*/,
+    const webrtc::CodecSpecificInfo* /*codecSpecificInfo*/,
+    int64_t /*renderTimeMs*/) {
+  DVLOG(3) << "Decode";
+
+  {
+    base::AutoLock auto_lock(lock_);
+    if (state_ == kUninitialized || decode_complete_callback_ == NULL) {
+      LOG(ERROR) << "The decoder has not initialized.";
+      return WEBRTC_VIDEO_CODEC_UNINITIALIZED;
+    }
+    if (state_ == kDecodeError) {
+      LOG(ERROR) << "Decoding error occurred.";
+      return WEBRTC_VIDEO_CODEC_ERROR;
+    }
+  }
+  if (missingFrames || !inputImage._completeFrame) {
+    DLOG(ERROR) << "Missing or incomplete frames.";
+    // Unlike the SW decoder in libvpx, hw decoder cannot handle broken frames.
+    // Return an error to request a key frame.
+    return WEBRTC_VIDEO_CODEC_ERROR;
+  }
+
+  if (inputImage._frameType == webrtc::kKeyFrame) {
+    frame_width_ = inputImage._encodedWidth;
+    frame_height_ = inputImage._encodedHeight;
+  }
+
+  // Copy WebRTC buffer to SHM buffer and create buffer data.
+  SHMBuffer* shm_buffer = GetSHM(inputImage._length);
+  if (!shm_buffer)
+    return WEBRTC_VIDEO_CODEC_ERROR;
+  memcpy(shm_buffer->shm->memory(), inputImage._buffer, inputImage._length);
+  BufferData buffer_data(next_bitstream_buffer_id_, inputImage._timeStamp,
+                         frame_width_, frame_height_, inputImage._length);
+  // Mask against 30 bits, to avoid (undefined) wraparound on signed integer.
+  next_bitstream_buffer_id_ = (next_bitstream_buffer_id_ + 1) & 0x3FFFFFFF;
+  std::pair<SHMBuffer*, BufferData> buffer_pair
+      = std::make_pair(shm_buffer, buffer_data);
+
+  // Store the buffer and the data to the queue.
+  {
+    base::AutoLock auto_lock(lock_);
+    buffers_to_be_decoded.push_back(buffer_pair);
+  }
+
+  vda_loop_proxy_->PostTask(FROM_HERE, base::Bind(
+      &RTCVideoDecoder::RequestBufferDecode, weak_this_));
+
+  return WEBRTC_VIDEO_CODEC_OK;
+}
+
+int32_t RTCVideoDecoder::RegisterDecodeCompleteCallback(
+    webrtc::DecodedImageCallback* callback) {
+  base::AutoLock auto_lock(lock_);
+  decode_complete_callback_ = callback;

[Ami GONE FROM CHROMIUM, 2013/06/11 23:48:05]

DCHECK d_c_c_ is NULL before this?

[wuchengli, 2013/06/13 10:28:07]

It is more consistent with other implementation without DCHECK. WebRTC does only
call it once though.

The header file doesn't say it's illegal.
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc...

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc...

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc...

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc...

+  return WEBRTC_VIDEO_CODEC_OK;
+}
+
+int32_t RTCVideoDecoder::Release() {
+  DVLOG(2) << "Release";
+  vda_loop_proxy_->PostTask(
+      FROM_HERE,
+      base::Bind(&RTCVideoDecoder::ReleaseInternal, weak_this_));
+  Wait();
+  return WEBRTC_VIDEO_CODEC_OK;
+}
+
+int32_t RTCVideoDecoder::Reset() {
+  DVLOG(2) << "Reset";
+  {
+    base::AutoLock auto_lock(lock_);
+    if (state_ == kUninitialized) {
+      LOG(ERROR) << "Decoder not initialized.";
+      return WEBRTC_VIDEO_CODEC_UNINITIALIZED;
+    }
+  }
+  vda_loop_proxy_->PostTask(FROM_HERE, base::Bind(
+      &RTCVideoDecoder::ResetInternal, weak_this_));
+  Wait();
+  return WEBRTC_VIDEO_CODEC_OK;
+}
+
+void RTCVideoDecoder::NotifyInitializeDone() {
+  DVLOG(2) << "NotifyInitializeDone";
+  NOTREACHED();
+}
+
+void RTCVideoDecoder::ProvidePictureBuffers(uint32 count,
+                                           const gfx::Size& size,

[Pawel Osciak, 2013/06/12 23:38:22]

indent

[wuchengli, 2013/06/13 10:28:07]

Done.

+                                           uint32 texture_target) {
+  DCHECK(vda_loop_proxy_->BelongsToCurrentThread());
+  DVLOG(3) << "ProvidePictureBuffers. texture_target=" << texture_target;
+  std::vector<uint32> texture_ids;
+  decoder_texture_target_ = texture_target;
+  if (!factories_->CreateTextures(
+      count, size, &texture_ids, decoder_texture_target_)) {
+    NotifyError(media::VideoDecodeAccelerator::PLATFORM_FAILURE);
+    return;
+  }
+
+  if (!vda_) {
+    LOG(ERROR) << "vda is NULL";
+    return;
+  }
+
+  std::vector<media::PictureBuffer> picture_buffers;
+  for (size_t i = 0; i < texture_ids.size(); ++i) {
+    picture_buffers.push_back(media::PictureBuffer(
+        next_picture_buffer_id_++, size, texture_ids[i]));
+    bool inserted = picture_buffers_in_decoder_.insert(std::make_pair(
+        picture_buffers.back().id(), picture_buffers.back())).second;
+    DCHECK(inserted);
+  }
+  vda_->AssignPictureBuffers(picture_buffers);
+}
+
+void RTCVideoDecoder::DismissPictureBuffer(int32 id) {
+  DVLOG(3) << "DismissPictureBuffer. id=" << id;
+  DCHECK(vda_loop_proxy_->BelongsToCurrentThread());
+
+  std::map<int32, media::PictureBuffer>::iterator it =
+      picture_buffers_in_decoder_.find(id);
+  if (it == picture_buffers_in_decoder_.end()) {
+    NOTREACHED() << "Missing picture buffer: " << id;
+    return;
+  }
+  factories_->DeleteTexture(it->second.texture_id());
+  picture_buffers_in_decoder_.erase(it);

[Ami GONE FROM CHROMIUM, 2013/06/11 23:48:05]

What if the texture is being drawn from?
I think you need an analog of r204513 (and r205347) for this to actually be
right.
The good news is I suspect nothing calls VDA::Client::DPB for your codepath.  
Maybe replace impl with NOTREACHED and TODO to adapt CLs above to here?

+}
+
+void RTCVideoDecoder::PictureReady(const media::Picture& picture) {
+  DVLOG(3) << "PictureReady";
+  DCHECK(vda_loop_proxy_->BelongsToCurrentThread());
+
+  std::map<int32, media::PictureBuffer>::iterator it =
+      picture_buffers_in_decoder_.find(picture.picture_buffer_id());
+  if (it == picture_buffers_in_decoder_.end()) {
+    NOTREACHED() << "Missing picture buffer: " << picture.picture_buffer_id();
+    NotifyError(media::VideoDecodeAccelerator::PLATFORM_FAILURE);
+    return;
+  }
+  const media::PictureBuffer& pb = it->second;
+
+  // Create a media::VideoFrame.
+  uint32_t timestamp = 0;
+  uint32_t width = 0, height = 0;
+  size_t size = 0;
+  GetBufferData(picture.bitstream_buffer_id(), &timestamp, &width, &height,
+                &size);
+  gfx::Rect visible_rect(width, height);
+  gfx::Size natural_size(width, height);
+  DCHECK(decoder_texture_target_);
+  // Convert timestamp from 90KHz to ms.
+  base::TimeDelta timestamp_ms = base::TimeDelta::FromInternalValue(
+      (uint64_t)timestamp * 1000 / 90);

[Ami GONE FROM CHROMIUM, 2013/06/11 23:48:05]

static_cast

[wuchengli, 2013/06/13 10:28:07]

Done.

+  scoped_refptr<media::VideoFrame> frame(
+      media::VideoFrame::WrapNativeTexture(
+          pb.texture_id(), decoder_texture_target_, pb.size(), visible_rect,
+          natural_size, timestamp_ms,
+          base::Bind(&media::GpuVideoDecoder::Factories::ReadPixels, factories_,
+                     pb.texture_id(), decoder_texture_target_,
+                     gfx::Size(visible_rect.width(), visible_rect.height())),
+          media::BindToCurrentLoop(base::Bind(
+              &RTCVideoDecoder::ReusePictureBuffer, weak_this_,
+              picture.picture_buffer_id()))));
+
+  // Create a webrtc::I420VideoFrame.
+  gfx::Rect rect = frame->visible_rect();
+  webrtc::I420VideoFrame decoded_image;
+  decoded_image.CreateEmptyFrame(

[Ami GONE FROM CHROMIUM, 2013/06/11 23:48:05]

OOC does this malloc(width*height*1.5)?
(it shouldn't)

[wuchengli, 2013/06/13 10:28:07]

I haven't finished http://webrtc-codereview.appspot.com/1298004/ yet. I'll
remove the malloc in that CL.

+      rect.width(), rect.height(),
+      rect.width(), rect.width() / 2, rect.width() / 2);
+  webrtc::RefCountImpl<NativeHandleImpl>* handle =
+      new webrtc::RefCountImpl<NativeHandleImpl>();
+  handle->SetHandle(frame.get());
+  decoded_image.set_native_handle(handle);
+  decoded_image.set_timestamp(timestamp);
+
+  // Send to decode callback.
+  webrtc::DecodedImageCallback *callback;
+  {
+    base::AutoLock auto_lock(lock_);
+    callback = decode_complete_callback_;
+  }
+  callback->Decoded(decoded_image);

[Ami GONE FROM CHROMIUM, 2013/06/11 23:48:05]

what if callback hasn't been set?

[wuchengli, 2013/06/13 10:28:07]

It shouldn't happen because Decode ensures it is set. I added a DCHECK.

+}
+
+void RTCVideoDecoder::NotifyEndOfBitstreamBuffer(int32 id) {
+  DVLOG(3) << "NotifyEndOfBitstreamBuffer. id=" << id;
+  DCHECK(vda_loop_proxy_->BelongsToCurrentThread());
+
+  std::map<int32, SHMBuffer*>::iterator it =
+      bitstream_buffers_in_decoder_.find(id);
+  if (it == bitstream_buffers_in_decoder_.end()) {
+    NotifyError(media::VideoDecodeAccelerator::PLATFORM_FAILURE);
+    NOTREACHED() << "Missing bitstream buffer: " << id;
+    return;
+  }
+
+  PutSHM(it->second);
+  bitstream_buffers_in_decoder_.erase(it);
+
+  RequestBufferDecode();
+}
+
+void RTCVideoDecoder::NotifyFlushDone() {
+  DVLOG(3) << "NotifyFlushDone";

[Ami GONE FROM CHROMIUM, 2013/06/11 23:48:05]

NOTREACHED?

[wuchengli, 2013/06/13 10:28:07]

Done.

+}
+
+void RTCVideoDecoder::NotifyResetDone() {
+  DCHECK(vda_loop_proxy_->BelongsToCurrentThread());
+  DVLOG(3) << "NotifyResetDone";
+
+  base::AutoLock auto_lock(lock_);
+  state_ = kInitialized;
+  decoder_waiter_.Signal();
+}
+
+void RTCVideoDecoder::NotifyError(media::VideoDecodeAccelerator::Error error) {
+  DCHECK(vda_loop_proxy_->BelongsToCurrentThread());
+  if (!vda_)
+    return;
+
+  DLOG(ERROR) << "VDA Error:" << error;
+  DestroyVDA();
+
+  base::AutoLock auto_lock(lock_);
+  state_ = kDecodeError;
+}
+
+void RTCVideoDecoder::WillDestroyCurrentMessageLoop() {
+  DCHECK(vda_loop_proxy_->BelongsToCurrentThread());
+  aborted_waiter_.Signal();

[wuchengli, 2013/06/10 15:24:22]

This makes sure the functions won't block forever if the vda thread is stopped.

+  factories_->Abort();
+}
+
+void RTCVideoDecoder::CreateVideoDecodeAccelerator(
+      media::VideoCodecProfile profile) {
+  DCHECK(vda_loop_proxy_->BelongsToCurrentThread());
+  DVLOG(3) << "CreateVideoDecodeAccelerator";
+  media::VideoDecodeAccelerator* vda =
+      factories_->CreateVideoDecodeAccelerator(profile, this);
+  // vda can be NULL if the codec type is not supported.
+  vda_.reset(vda);
+  weak_this_ = weak_factory_.GetWeakPtr();
+
+  base::AutoLock auto_lock(lock_);
+  state_ = kInitialized;
+  decoder_waiter_.Signal();
+  DVLOG(3) << "CreateVideoDecodeAccelerator end";
+}
+
+void RTCVideoDecoder::RequestBufferDecode() {
+  if(!CanMoreDecodeWorkBeDone())
+    return;
+
+  // Get a buffer and data from the queue.
+  std::pair<SHMBuffer*, BufferData> *buffer_pair;
+  {
+    base::AutoLock auto_lock(lock_);
+    if (buffers_to_be_decoded.size() == 0)
+      return;
+    buffer_pair = &buffers_to_be_decoded.front();
+    buffers_to_be_decoded.pop_front();
+  }
+  SHMBuffer* shm_buffer = buffer_pair->first;
+  BufferData buffer_data = buffer_pair->second;
+
+  // Create a BitstreamBuffer and send to VDA to decode.
+  media::BitstreamBuffer bitstream_buffer(
+      buffer_data.bitstream_buffer_id, shm_buffer->shm->handle(),
+      buffer_data.size);
+  bool inserted = bitstream_buffers_in_decoder_.insert(std::make_pair(
+      bitstream_buffer.id(), shm_buffer)).second;
+  DCHECK(inserted);
+  RecordBufferData(buffer_data);
+  vda_->Decode(bitstream_buffer);
+}
+
+// Maximum number of concurrent VDA::Decode() operations GVD will maintain.

[Ami GONE FROM CHROMIUM, 2013/06/11 23:48:05]

s/GVD/RVD/

[wuchengli, 2013/06/13 10:28:07]

Done.

+// Higher values allow better pipelining in the GPU, but also require more
+// resources.
+enum { kMaxInFlightDecodes = 10 };
+
+bool RTCVideoDecoder::CanMoreDecodeWorkBeDone() {
+  return bitstream_buffers_in_decoder_.size() < kMaxInFlightDecodes;
+}
+
+void RTCVideoDecoder::ReleaseInternal() {
+  DCHECK(vda_loop_proxy_->BelongsToCurrentThread());
+  DVLOG(2) << "ReleaseInternal";
+
+  if (vda_)
+    DestroyVDA();
+
+  base::AutoLock auto_lock(lock_);
+  state_ = kUninitialized;
+  decoder_waiter_.Signal();
+}
+
+void RTCVideoDecoder::ResetInternal() {
+  DCHECK(vda_loop_proxy_->BelongsToCurrentThread());
+  vda_->Reset();
+  decoder_waiter_.Signal();

[Ami GONE FROM CHROMIUM, 2013/06/11 23:48:05]

Why this Signal()?  (I expected the NotifyResetDone Signal() to be the only way
to signal completion)

[wuchengli, 2013/06/13 10:28:07]

Argh... Fixed.

+}
+
+void RTCVideoDecoder::ReusePictureBuffer(int64 picture_buffer_id) {
+  DCHECK(vda_loop_proxy_->BelongsToCurrentThread());
+  DVLOG(3) << "ReusePictureBuffer. id=" << picture_buffer_id;
+
+  if (!vda_)
+    return;
+  vda_->ReusePictureBuffer(picture_buffer_id);
+}
+
+void RTCVideoDecoder::Wait() {
+  base::WaitableEvent* objects[] = {&aborted_waiter_,
+                                    &decoder_waiter_};
+  base::WaitableEvent::WaitMany(objects, arraysize(objects));
+}
+
+void RTCVideoDecoder::DestroyTextures() {
+  DCHECK(vda_loop_proxy_->BelongsToCurrentThread());
+  for (std::map<int32, media::PictureBuffer>::iterator it =
+          picture_buffers_in_decoder_.begin();
+          it != picture_buffers_in_decoder_.end(); ++it) {
+    factories_->DeleteTexture(it->second.texture_id());
+  }
+  picture_buffers_in_decoder_.clear();
+}
+
+void RTCVideoDecoder::DestroyVDA() {
+  DVLOG(2) << "DestroyVDA";
+  DCHECK(vda_loop_proxy_->BelongsToCurrentThread());
+  if (vda_)
+    vda_.release()->Destroy();
+  DestroyTextures();
+}
+
+// Size of shared-memory segments we allocate.  Since we reuse them we let them
+// be on the beefy side.
+static const size_t kSharedMemorySegmentBytes = 100 << 10;
+
+RTCVideoDecoder::SHMBuffer* RTCVideoDecoder::GetSHM(size_t min_size) {
+  {
+    // Reuse a SHM if possible.
+    base::AutoLock auto_lock(lock_);
+    if (!available_shm_segments_.empty() &&
+        available_shm_segments_.back()->size >= min_size) {
+      SHMBuffer* ret = available_shm_segments_.back();
+      available_shm_segments_.pop_back();
+      return ret;
+    }
+  }
+  // Create a new shared memory. This is done in main thread.
+  size_t size_to_allocate = std::max(min_size, kSharedMemorySegmentBytes);
+  base::SharedMemory *shm = factories_->CreateSharedMemory(size_to_allocate);
+  if (!shm)
+    return NULL;
+  return new SHMBuffer(shm, size_to_allocate);
+}
+
+void RTCVideoDecoder::PutSHM(SHMBuffer* shm_buffer) {
+  DCHECK(vda_loop_proxy_->BelongsToCurrentThread());
+  base::AutoLock auto_lock(lock_);
+  available_shm_segments_.push_back(shm_buffer);
+}
+
+void RTCVideoDecoder::RecordBufferData(const BufferData& buffer_data) {
+  input_buffer_data_.push_front(buffer_data);
+  // Why this value?  Because why not.  avformat.h:MAX_REORDER_DELAY is 16, but
+  // that's too small for some pathological B-frame test videos.  The cost of
+  // using too-high a value is low (192 bits per extra slot).
+  static const size_t kMaxInputBufferDataSize = 128;
+  // Pop from the back of the list, because that's the oldest and least likely
+  // to be useful in the future data.
+  if (input_buffer_data_.size() > kMaxInputBufferDataSize)
+    input_buffer_data_.pop_back();
+}
+
+void RTCVideoDecoder::GetBufferData(
+    int32 bitstream_buffer_id, uint32_t* timestamp, uint32_t* width,
+    uint32_t* height, size_t *size) {
+  for (std::list<BufferData>::const_iterator it =
+           input_buffer_data_.begin(); it != input_buffer_data_.end();

[Ami GONE FROM CHROMIUM, 2013/06/11 23:48:05]

This is unlikely to impact perf, and I think this is just copy/pasta from GVD,
but:
it's probably true that the buffer we're looking for here is at the back of the
list; might be better to use rbegin/rend.  Just a thought.

[wuchengli, 2013/06/13 10:28:07]

I found the element was not removed from the list. I added the code to remove it
when it's found. Then the buffer should be in the front. Right?

What does the comment in RecordBufferData mean? Does it only apply to H264?

+       ++it) {
+    if (it->bitstream_buffer_id != bitstream_buffer_id)
+      continue;
+    *timestamp = it->timestamp;
+    *width = it->width;
+    *height = it->height;
+    return;
+  }
+  NOTREACHED() << "Missing bitstream buffer id: " << bitstream_buffer_id;
+}
+
+RTCVideoDecoder::SHMBuffer::SHMBuffer(base::SharedMemory* m, size_t s)
+    : shm(m), size(s) {
+}
+
+RTCVideoDecoder::SHMBuffer::~SHMBuffer() {}
+
+RTCVideoDecoder::BufferData::BufferData(
+    int32 bbid, uint32_t ts, int w, int h, size_t s)
+    : bitstream_buffer_id(bbid), timestamp(ts), width(w),
+      height(h), size(s) {
+}
+
+RTCVideoDecoder::BufferData::~BufferData() {}
+
+} // namespace content