Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: content/renderer/media/rtc_video_decoder_factory.cc

Issue 13890012: Integrate VDA with WebRTC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "content/renderer/media/rtc_video_decoder_factory.h"
6
7 namespace content {
8
9 RTCVideoDecoderFactory::RTCVideoDecoderFactory(
10 const scoped_refptr<base::MessageLoopProxy>& chrome_loop_proxy,
11 const scoped_refptr<media::GpuVideoDecoder::Factories>& gpu_factories)
12 : chrome_loop_proxy_(chrome_loop_proxy),
Ami GONE FROM CHROMIUM 2013/04/26 00:42:05 nit: +2 additional indent this and the next line
wuchengli 2013/05/08 15:58:56 Done.
13 gpu_factories_(gpu_factories) {
14
15 }
16
17 webrtc::VideoDecoder* RTCVideoDecoderFactory::CreateVideoDecoder(
18 webrtc::VideoCodecType type) {
19 if (type == webrtc::kVideoCodecVP8) {
Ami GONE FROM CHROMIUM 2013/04/26 00:42:05 why not also allow h264 here?
Pawel Osciak 2013/04/26 07:08:01 This should be decided by each vda implementation
wuchengli 2013/05/08 15:58:56 H264 is not in the enum. All enum values are kVide
20 scoped_refptr<media::VideoDecoder> gpu_video_decoder =
21 new media::GpuVideoDecoder(chrome_loop_proxy_, gpu_factories_);
22
23 return new RTCVideoDecoderBridge(gpu_video_decoder, chrome_loop_proxy_);
24 }
25 return NULL;
26 }
27
28 void RTCVideoDecoderFactory::DestroyVideoDecoder(
29 webrtc::VideoDecoder* decoder) {
30 delete decoder;
31 }
32
33 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698