Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1523)

Issue 13890009: Simplify StackBounds. (Closed)

Created:
7 years, 8 months ago by lgombos
Modified:
7 years, 8 months ago
CC:
blink-reviews, loislo+blink_chromium.org, jeez, yurys+blink_chromium.org, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Simplify StackBounds. StackBounds::isGrowingDownward() is always true so it can be removed. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149078

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -41 lines) Patch
M Source/wtf/StackBounds.h View 4 chunks +4 lines, -18 lines 0 comments Download
M Source/wtf/StackStats.cpp View 9 chunks +0 lines, -23 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
lgombos
Cleanup as it has been pointed out in comment - https://codereview.chromium.org/13901012/#msg2 .
7 years, 8 months ago (2013-04-23 04:59:41 UTC) #1
abarth-chromium
LGTM
7 years, 8 months ago (2013-04-23 05:08:56 UTC) #2
Julien - ping for review
LGTM2
7 years, 8 months ago (2013-04-23 14:46:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/13890009/1
7 years, 8 months ago (2013-04-23 14:49:46 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=5012
7 years, 8 months ago (2013-04-23 15:52:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/13890009/1
7 years, 8 months ago (2013-04-23 20:33:34 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=2547
7 years, 8 months ago (2013-04-23 21:44:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/13890009/1
7 years, 8 months ago (2013-04-23 22:27:07 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=2574
7 years, 8 months ago (2013-04-23 22:57:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/13890009/1
7 years, 8 months ago (2013-04-23 23:21:37 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=2586
7 years, 8 months ago (2013-04-23 23:59:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/13890009/1
7 years, 8 months ago (2013-04-24 09:00:37 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=2649
7 years, 8 months ago (2013-04-24 09:14:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/13890009/32001
7 years, 8 months ago (2013-04-24 21:01:17 UTC) #14
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) test_shell_tests, webkit_lint, webkit_tests, webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=5274
7 years, 8 months ago (2013-04-24 21:30:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/13890009/32001
7 years, 8 months ago (2013-04-24 21:35:12 UTC) #16
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-24 21:39:49 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/13890009/32001
7 years, 8 months ago (2013-04-24 22:36:53 UTC) #18
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-24 22:45:29 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/13890009/32001
7 years, 8 months ago (2013-04-25 05:10:12 UTC) #20
commit-bot: I haz the power
7 years, 8 months ago (2013-04-25 05:21:34 UTC) #21
Message was sent while issue was closed.
Change committed as 149078

Powered by Google App Engine
This is Rietveld 408576698