Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1388993002: PPC: [builtins] Make sure argument count is always valid for C++ builtins. (Closed)

Created:
5 years, 2 months ago by MTBrandyberry
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [builtins] Make sure argument count is always valid for C++ builtins. Port 9c8262f11e3d6359874a63f25a31c6ddfba3dc1c Original commit message: When calling into C++ builtins, we need to make sure that the argument count register contains the correct number of arguments, otherwise the CEntryStub will not be able to leave the stack in the correct state. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG=v8:4413 LOG=n Committed: https://crrev.com/3d1d7f3622d81c92df9a574293b9a48e1eee10d3 Cr-Commit-Position: refs/heads/master@{#31126}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M src/ppc/builtins-ppc.cc View 2 chunks +24 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 2 months ago (2015-10-06 14:43:01 UTC) #1
JoranSiu
lgtm
5 years, 2 months ago (2015-10-06 14:47:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388993002/1
5 years, 2 months ago (2015-10-06 14:51:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 15:13:23 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 15:13:51 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d1d7f3622d81c92df9a574293b9a48e1eee10d3
Cr-Commit-Position: refs/heads/master@{#31126}

Powered by Google App Engine
This is Rietveld 408576698