Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1388983003: [iOS][GN] Port ios_net_unittests to build with gn. (Closed)

Created:
5 years, 2 months ago by sdefresne
Modified:
5 years, 2 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS][GN] Port ios_net_unittests to build with gn. Add new BUILD.gn file exporting //ios/net and //ios/net:ios_net_unittests targets (corresponding to ios_net and ios_net_unittests with gyp) and add dependency on the unit test target in //BUILD.gn. Add missing dependency on //build/config/mac:compiler when targetting iOS or mac in //build/config/compiler/BUILD.gn (paralleling the other deps on //build/config/${system}:compiler). Change the "-arch" value to target fat architecture "arm64" & "armv7" when current_cpu is "arm" (better to have fat binaries working on all devices since it is not possible currently to target "armv7" with gn). BUG=459705 Committed: https://crrev.com/998e85859261f3a9d1491b6f106b32b5c7dce775 Cr-Commit-Position: refs/heads/master@{#352827}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M build/config/mac/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A ios/net/BUILD.gn View 1 chunk +76 lines, -0 lines 0 comments Download
M ios/net/ios_net.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ios/net/ios_net_unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sdefresne
dpranke: please take a look at the gn changes ellyjones: can you review as //ios/net ...
5 years, 2 months ago (2015-10-06 16:45:19 UTC) #2
Dirk Pranke
lgtm
5 years, 2 months ago (2015-10-06 23:55:45 UTC) #3
Elly Fong-Jones
lgtm
5 years, 2 months ago (2015-10-07 13:22:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388983003/1
5 years, 2 months ago (2015-10-07 13:23:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-07 13:36:56 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 13:37:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/998e85859261f3a9d1491b6f106b32b5c7dce775
Cr-Commit-Position: refs/heads/master@{#352827}

Powered by Google App Engine
This is Rietveld 408576698