Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3974)

Unified Diff: chrome/chrome_installer.gypi

Issue 1388943004: Add GCAPI to the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/common/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_installer.gypi
diff --git a/chrome/chrome_installer.gypi b/chrome/chrome_installer.gypi
index f448ad22eb467b9024fa547c775a7c9e03edab5b..b7b6a3c68071d420f95cdf005bc1e33167a8284f 100644
--- a/chrome/chrome_installer.gypi
+++ b/chrome/chrome_installer.gypi
@@ -12,6 +12,7 @@
['OS=="win"', {
'targets': [
{
+ # GN version: //chrome/installer/gcapi
'target_name': 'gcapi_dll',
'type': 'loadable_module',
'dependencies': [
@@ -26,6 +27,7 @@
],
},
{
+ # GN version: //chrome/installer/gcapi:lib
'target_name': 'gcapi_lib',
'type': 'static_library',
'dependencies': [
@@ -46,10 +48,9 @@
'installer/gcapi/gcapi_reactivation.cc',
'installer/gcapi/gcapi_reactivation.h',
],
- # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
- 'msvs_disabled_warnings': [ 4267, ],
},
{
+ # GN version: //chrome/installer/gcapi:gcapi_test
'target_name': 'gcapi_test',
'type': 'executable',
'dependencies': [
« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/common/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698