third_party/WebKit/Source/core/dom/Element.cpp - Issue 1388903002: className should be allowed to be a whitespace-only string

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 1388903002: className should be allowed to be a whitespace-only string (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/Element.cpp

diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp

index 9034a842ff08eed765667e4d3dfa4a467b18e33b..7aae320450f13bc6eb8e7cbec742a2cee3db762c 100644

--- a/third_party/WebKit/Source/core/dom/Element.cpp

+++ b/third_party/WebKit/Source/core/dom/Element.cpp

@@ -1240,7 +1240,7 @@ static inline bool classStringHasClassName(const CharacterType* characters, unsi

++i;

} while (i < length);

- return i < length;

+ return i <= length;

tkent 2015/10/06 07:19:02 It means this function always returns |true|. Do y

}

static inline bool classStringHasClassName(const AtomicString& newClassString)

« no previous file with comments | « no previous file | no next file » | no next file with comments »