Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Issue 1388813002: Remove dead helper methods from Block AST node (Closed)

Created:
5 years, 2 months ago by adamk
Modified:
5 years, 2 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com, neis
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove dead helper methods from Block AST node R=rossberg@chromium.org Committed: https://crrev.com/299c72bc889c09d4a8e1aa46be4156cd0b87054e Cr-Commit-Position: refs/heads/master@{#31119}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M src/ast.h View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
adamk
5 years, 2 months ago (2015-10-05 19:06:32 UTC) #1
rossberg
lgtm
5 years, 2 months ago (2015-10-06 05:25:50 UTC) #2
rossberg
lgtm lgtm
5 years, 2 months ago (2015-10-06 05:25:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388813002/1
5 years, 2 months ago (2015-10-06 06:14:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 06:16:41 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 06:16:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/299c72bc889c09d4a8e1aa46be4156cd0b87054e
Cr-Commit-Position: refs/heads/master@{#31119}

Powered by Google App Engine
This is Rietveld 408576698