Source/WebCore/html/HTMLSelectElement.cpp - Issue 13888009: Mouse press should focus on any types of form controls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/html/HTMLSelectElement.cpp

Issue 13888009: Mouse press should focus on any types of form controls. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/WebCore/html/HTMLSelectElement.cpp

diff --git a/Source/WebCore/html/HTMLSelectElement.cpp b/Source/WebCore/html/HTMLSelectElement.cpp

index e51408a387b6da97b5073a57cd3d6d61c4df28f7..376205177fb637c985b2c8706fdb27033d71b4c5 100644

--- a/Source/WebCore/html/HTMLSelectElement.cpp

+++ b/Source/WebCore/html/HTMLSelectElement.cpp

@@ -323,13 +323,6 @@ bool HTMLSelectElement::isKeyboardFocusable(KeyboardEvent* event) const

return HTMLFormControlElementWithState::isKeyboardFocusable(event);

}

-bool HTMLSelectElement::isMouseFocusable() const

- if (renderer())

- return isFocusable();

- return HTMLFormControlElementWithState::isMouseFocusable();

bool HTMLSelectElement::canSelectAll() const

{

return !usesMenuList();

« no previous file with comments | « Source/WebCore/html/HTMLSelectElement.h ('k') | Source/WebCore/html/HTMLTextAreaElement.h » ('j') | no next file with comments »