Source/WebCore/html/HTMLInputElement.h - Issue 13888009: Mouse press should focus on any types of form controls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/html/HTMLInputElement.h

Issue 13888009: Mouse press should focus on any types of form controls. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/WebCore/html/HTMLInputElement.h

diff --git a/Source/WebCore/html/HTMLInputElement.h b/Source/WebCore/html/HTMLInputElement.h

index 71e2a6d0ea4521681ec46651bb5c6d8b8d27c1bb..7ad08254eb8a5cc4286d4decd810f46839568a2f 100644

--- a/Source/WebCore/html/HTMLInputElement.h

+++ b/Source/WebCore/html/HTMLInputElement.h

@@ -254,7 +254,6 @@ public:

// Functions for InputType classes.

void setValueInternal(const String&, TextFieldEventBehavior);

bool isTextFormControlKeyboardFocusable(KeyboardEvent*) const;

- bool isTextFormControlMouseFocusable() const;

bool valueAttributeWasUpdatedAfterParsing() const { return m_valueAttributeWasUpdatedAfterParsing; }

void cacheSelectionInResponseToSetValue(int caretOffset) { cacheSelection(caretOffset, caretOffset, SelectionHasNoDirection); }

@@ -320,7 +319,6 @@ private:

virtual bool hasCustomFocusLogic() const OVERRIDE;

virtual bool isKeyboardFocusable(KeyboardEvent*) const;

- virtual bool isMouseFocusable() const;

virtual bool isEnumeratable() const;

virtual bool supportLabels() const OVERRIDE;

virtual void updateFocusAppearance(bool restorePreviousSelection);