Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Side by Side Diff: Source/WebCore/html/HTMLInputElement.cpp

Issue 13888009: Mouse press should focus on any types of form controls. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/WebCore/html/HTMLInputElement.h ('k') | Source/WebCore/html/HTMLSelectElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 371 matching lines...) Expand 10 before | Expand all | Expand 10 after
382 bool HTMLInputElement::hasCustomFocusLogic() const 382 bool HTMLInputElement::hasCustomFocusLogic() const
383 { 383 {
384 return m_inputType->hasCustomFocusLogic(); 384 return m_inputType->hasCustomFocusLogic();
385 } 385 }
386 386
387 bool HTMLInputElement::isKeyboardFocusable(KeyboardEvent* event) const 387 bool HTMLInputElement::isKeyboardFocusable(KeyboardEvent* event) const
388 { 388 {
389 return m_inputType->isKeyboardFocusable(event); 389 return m_inputType->isKeyboardFocusable(event);
390 } 390 }
391 391
392 bool HTMLInputElement::isMouseFocusable() const
393 {
394 return m_inputType->isMouseFocusable();
395 }
396
397 bool HTMLInputElement::isTextFormControlKeyboardFocusable(KeyboardEvent* event) const 392 bool HTMLInputElement::isTextFormControlKeyboardFocusable(KeyboardEvent* event) const
398 { 393 {
399 return HTMLTextFormControlElement::isKeyboardFocusable(event); 394 return HTMLTextFormControlElement::isKeyboardFocusable(event);
400 } 395 }
401 396
402 bool HTMLInputElement::isTextFormControlMouseFocusable() const
403 {
404 return HTMLTextFormControlElement::isMouseFocusable();
405 }
406
407 void HTMLInputElement::updateFocusAppearance(bool restorePreviousSelection) 397 void HTMLInputElement::updateFocusAppearance(bool restorePreviousSelection)
408 { 398 {
409 if (isTextField()) { 399 if (isTextField()) {
410 if (!restorePreviousSelection || !hasCachedSelection()) 400 if (!restorePreviousSelection || !hasCachedSelection())
411 select(); 401 select();
412 else 402 else
413 restoreCachedSelection(); 403 restoreCachedSelection();
414 if (document()->frame()) 404 if (document()->frame())
415 document()->frame()->selection()->revealSelection(); 405 document()->frame()->selection()->revealSelection();
416 } else 406 } else
(...skipping 1555 matching lines...) Expand 10 before | Expand all | Expand 10 after
1972 } 1962 }
1973 1963
1974 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI) 1964 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
1975 PassRefPtr<RenderStyle> HTMLInputElement::customStyleForRenderer() 1965 PassRefPtr<RenderStyle> HTMLInputElement::customStyleForRenderer()
1976 { 1966 {
1977 return m_inputType->customStyleForRenderer(document()->styleResolver()->styl eForElement(this)); 1967 return m_inputType->customStyleForRenderer(document()->styleResolver()->styl eForElement(this));
1978 } 1968 }
1979 #endif 1969 #endif
1980 1970
1981 } // namespace 1971 } // namespace
OLDNEW
« no previous file with comments | « Source/WebCore/html/HTMLInputElement.h ('k') | Source/WebCore/html/HTMLSelectElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698