Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Side by Side Diff: Source/WebCore/html/HTMLFormControlElement.cpp

Issue 13888009: Mouse press should focus on any types of form controls. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/WebCore/html/HTMLFormControlElement.h ('k') | Source/WebCore/html/HTMLInputElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after
324 } 324 }
325 325
326 bool HTMLFormControlElement::isKeyboardFocusable(KeyboardEvent* event) const 326 bool HTMLFormControlElement::isKeyboardFocusable(KeyboardEvent* event) const
327 { 327 {
328 if (isFocusable()) 328 if (isFocusable())
329 if (document()->frame()) 329 if (document()->frame())
330 return document()->frame()->eventHandler()->tabsToAllFormControls(ev ent); 330 return document()->frame()->eventHandler()->tabsToAllFormControls(ev ent);
331 return false; 331 return false;
332 } 332 }
333 333
334 bool HTMLFormControlElement::isMouseFocusable() const
335 {
336 return false;
337 }
338
339 short HTMLFormControlElement::tabIndex() const 334 short HTMLFormControlElement::tabIndex() const
340 { 335 {
341 // Skip the supportsFocus check in HTMLElement. 336 // Skip the supportsFocus check in HTMLElement.
342 return Element::tabIndex(); 337 return Element::tabIndex();
343 } 338 }
344 339
345 bool HTMLFormControlElement::recalcWillValidate() const 340 bool HTMLFormControlElement::recalcWillValidate() const
346 { 341 {
347 if (m_dataListAncestorState == Unknown) { 342 if (m_dataListAncestorState == Unknown) {
348 for (ContainerNode* ancestor = parentNode(); ancestor; ancestor = ancest or->parentNode()) { 343 for (ContainerNode* ancestor = parentNode(); ancestor; ancestor = ancest or->parentNode()) {
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
483 } 478 }
484 479
485 void HTMLFormControlElement::reportMemoryUsage(MemoryObjectInfo* memoryObjectInf o) const 480 void HTMLFormControlElement::reportMemoryUsage(MemoryObjectInfo* memoryObjectInf o) const
486 { 481 {
487 MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::DOM); 482 MemoryClassInfo info(memoryObjectInfo, this, WebCoreMemoryTypes::DOM);
488 LabelableElement::reportMemoryUsage(memoryObjectInfo); 483 LabelableElement::reportMemoryUsage(memoryObjectInfo);
489 info.addMember(m_validationMessage, "validationMessage"); 484 info.addMember(m_validationMessage, "validationMessage");
490 } 485 }
491 486
492 } // namespace Webcore 487 } // namespace Webcore
OLDNEW
« no previous file with comments | « Source/WebCore/html/HTMLFormControlElement.h ('k') | Source/WebCore/html/HTMLInputElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698