Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1388793003: Describe .nc files as "No Compile Test" suites and link doc. (Closed)

Created:
5 years, 2 months ago by scheib
Modified:
5 years, 2 months ago
Reviewers:
danakj
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Describe .nc files as "No Compile Test" suites and link doc. Committed: https://crrev.com/0411d8f76830775e6e0f3bb02c9506a591471ed5 Cr-Commit-Position: refs/heads/master@{#354823}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M base/bind_unittest.nc View 1 chunk +3 lines, -0 lines 0 comments Download
M base/callback_list_unittest.nc View 1 chunk +3 lines, -0 lines 0 comments Download
M base/callback_unittest.nc View 1 chunk +3 lines, -0 lines 0 comments Download
M base/memory/scoped_ptr_unittest.nc View 1 chunk +3 lines, -0 lines 0 comments Download
M base/memory/weak_ptr_unittest.nc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
scheib
5 years, 2 months ago (2015-10-05 21:55:08 UTC) #2
scheib
🐇
5 years, 2 months ago (2015-10-18 02:28:04 UTC) #3
danakj
LGTM
5 years, 2 months ago (2015-10-19 18:43:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388793003/1
5 years, 2 months ago (2015-10-19 19:07:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-19 19:30:02 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 19:30:37 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0411d8f76830775e6e0f3bb02c9506a591471ed5
Cr-Commit-Position: refs/heads/master@{#354823}

Powered by Google App Engine
This is Rietveld 408576698