Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: pkg/analysis_server/tool/spec/spec_input.html

Issue 1388783003: Spec change: include covering expressions into Extract Local protocol. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/tool/spec/generated/java/types/ExtractLocalVariableFeedback.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/tool/spec/spec_input.html
diff --git a/pkg/analysis_server/tool/spec/spec_input.html b/pkg/analysis_server/tool/spec/spec_input.html
index 06de8fff576dbd11d6bac9a0e1d997342cf4d93c..f9a40f9e9287d81edfd4455b2201be85e3dc92d8 100644
--- a/pkg/analysis_server/tool/spec/spec_input.html
+++ b/pkg/analysis_server/tool/spec/spec_input.html
@@ -4011,14 +4011,28 @@
</refactoring>
<refactoring kind="EXTRACT_LOCAL_VARIABLE">
<p>
- Create a local variable initialized by a specified
- expression.
+ Create a local variable initialized by the expression that covers
+ the specified selection.
</p>
<p>
- It is an error if the range contains anything other than a
- complete expression (no partial expressions are allowed).
+ It is an error if the selection range is not covered by a
+ complete expression.
</p>
<feedback>
+ <field name="coveringExpressionOffsets">
+ <list><ref>int</ref></list>
+ <p>
+ The offsets of the expressions that cover the specified
+ selection, from the down most to the up most.
+ </p>
+ </field>
+ <field name="coveringExpressionLengths">
+ <list><ref>int</ref></list>
+ <p>
+ The lengths of the expressions that cover the specified
+ selection, from the down most to the up most.
+ </p>
+ </field>
<field name="names">
<list><ref>String</ref></list>
<p>
« no previous file with comments | « pkg/analysis_server/tool/spec/generated/java/types/ExtractLocalVariableFeedback.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698