Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1388783003: Spec change: include covering expressions into Extract Local protocol. (Closed)

Created:
5 years, 2 months ago by scheglov
Modified:
5 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Spec change: include covering expressions into Extract Local protocol. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/b107dec41a75be04cbbf5ec81f4369ecff6e89f5

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -17 lines) Patch
M pkg/analysis_server/doc/api.html View 1 chunk +17 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 8 chunks +59 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/types/ExtractLocalVariableFeedback.java View 8 chunks +52 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +18 lines, -4 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 2 months ago (2015-10-05 17:57:23 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/1388783003/diff/1/pkg/analysis_server/tool/spec/spec_input.html File pkg/analysis_server/tool/spec/spec_input.html (right): https://codereview.chromium.org/1388783003/diff/1/pkg/analysis_server/tool/spec/spec_input.html#newcode9 pkg/analysis_server/tool/spec/spec_input.html:9: <h1 style="color:#999999">Version <version>1.10.0</version></h1> We'll need to increment the ...
5 years, 2 months ago (2015-10-05 18:03:30 UTC) #2
scheglov
5 years, 2 months ago (2015-10-05 21:44:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b107dec41a75be04cbbf5ec81f4369ecff6e89f5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698