Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: ppapi/proxy/raw_var_data_unittest.cc

Issue 13887007: Introduce RawVarData and associated classes for serializing PP_Vars (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/proxy/raw_var_data_unittest.cc
diff --git a/ppapi/proxy/raw_var_data_unittest.cc b/ppapi/proxy/raw_var_data_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..1fdf4c6245e0ad5ba3da2de92c519317865787b3
--- /dev/null
+++ b/ppapi/proxy/raw_var_data_unittest.cc
@@ -0,0 +1,241 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ppapi/proxy/ppapi_proxy_test.h"
+
+#include "ppapi/proxy/raw_var_data.h"
+#include "ppapi/shared_impl/array_var.h"
+#include "ppapi/shared_impl/dictionary_var.h"
+#include "ppapi/shared_impl/proxy_lock.h"
+#include "ppapi/shared_impl/var.h"
+
+namespace ppapi {
+namespace proxy {
+
+namespace {
+
+class RawVarDataTest : public PluginProxyTest {
+ public:
+ RawVarDataTest() {}
+};
+
+bool Equals(const PP_Var& expected,
+ const PP_Var& actual,
+ base::hash_map<int64_t, int64_t>* visited_map) {
+ if (expected.type != actual.type)
+ return false;
+ if (VarTracker::IsVarTypeRefcounted(expected.type)) {
+ base::hash_map<int64_t, int64_t>::iterator it =
+ visited_map->find(expected.value.as_id);
+ if (it != visited_map->end())
+ return it->second == actual.value.as_id;
+ else
+ (*visited_map)[expected.value.as_id] = actual.value.as_id;
+ }
+ switch (expected.type) {
+ case PP_VARTYPE_UNDEFINED:
+ return true;
+ case PP_VARTYPE_NULL:
+ return true;
+ case PP_VARTYPE_BOOL:
+ return expected.value.as_bool == actual.value.as_bool;
+ case PP_VARTYPE_INT32:
+ return expected.value.as_int == actual.value.as_int;
+ case PP_VARTYPE_DOUBLE:
+ return expected.value.as_double == actual.value.as_double;
+ case PP_VARTYPE_OBJECT:
+ return expected.value.as_id == actual.value.as_id;
+ case PP_VARTYPE_STRING: {
+ StringVar* expected_var = StringVar::FromPPVar(expected);
+ StringVar* actual_var = StringVar::FromPPVar(actual);
+ if (!expected_var || !actual_var)
+ return expected_var == actual_var;
+ return expected_var->value() == expected_var->value();
+ }
+ case PP_VARTYPE_ARRAY_BUFFER: {
+ ArrayBufferVar* expected_var = ArrayBufferVar::FromPPVar(expected);
+ ArrayBufferVar* actual_var = ArrayBufferVar::FromPPVar(actual);
+ if (!expected_var || !actual_var)
+ return expected_var == actual_var;
+ std::string expected_data(static_cast<const char*>(expected_var->Map()),
+ expected_var->ByteLength());
+ std::string actual_data(static_cast<const char*>(actual_var->Map()),
+ actual_var->ByteLength());
+ return expected_data == actual_data;
+ }
+ case PP_VARTYPE_ARRAY: {
+ ArrayVar* expected_var = ArrayVar::FromPPVar(expected);
+ ArrayVar* actual_var = ArrayVar::FromPPVar(actual);
+ if (!expected_var || !actual_var)
+ return expected_var == actual_var;
+ if (expected_var->elements().size() != actual_var->elements().size())
+ return false;
+ for (size_t i = 0; i < expected_var->elements().size(); ++i) {
+ if (!Equals(expected_var->elements()[i].get(),
+ actual_var->elements()[i].get(),
+ visited_map)) {
+ return false;
+ }
+ }
+ return true;
+ }
+ case PP_VARTYPE_DICTIONARY: {
+ DictionaryVar* expected_var = DictionaryVar::FromPPVar(expected);
+ DictionaryVar* actual_var = DictionaryVar::FromPPVar(actual);
+ if (!expected_var || !actual_var)
+ return expected_var == actual_var;
+ if (expected_var->key_value_map().size() !=
+ actual_var->key_value_map().size())
+ return false;
+ DictionaryVar::KeyValueMap::const_iterator expected_iter =
+ expected_var->key_value_map().begin();
+ DictionaryVar::KeyValueMap::const_iterator actual_iter =
+ actual_var->key_value_map().begin();
+ for ( ; expected_iter != expected_var->key_value_map().end() &&
+ actual_iter != actual_var->key_value_map().end();
+ ++expected_iter, ++actual_iter) {
+ if (expected_iter->first != actual_iter->first)
+ return false;
+ if (!Equals(expected_iter->second.get(),
+ actual_iter->second.get(),
+ visited_map)) {
+ return false;
+ }
+ }
+ return true;
+ }
+ }
+ NOTREACHED();
+ return false;
+}
+
+bool Equals(const PP_Var& expected,
+ const PP_Var& actual) {
+ base::hash_map<int64_t, int64_t> visited_map;
+ return Equals(expected, actual, &visited_map);
+}
+
+PP_Var WriteAndRead(const PP_Var& var) {
+ PP_Instance dummy_instance = 1234;
+ scoped_ptr<RawVarDataGraph> expected_data(RawVarDataGraph::Create(
+ var, dummy_instance));
+ IPC::Message m;
+ expected_data->Write(&m);
+ PickleIterator iter(m);
+ scoped_ptr<RawVarDataGraph> actual_data(RawVarDataGraph::Read(&m, &iter));
+ return actual_data->CreatePPVar(dummy_instance);
+}
+
+// Assumes a ref for var.
+bool WriteReadAndCompare(const PP_Var& var) {
+ ScopedPPVar expected(ScopedPPVar::PassRef(), var);
+ ScopedPPVar actual(ScopedPPVar::PassRef(), WriteAndRead(expected.get()));
+ return Equals(expected.get(), actual.get());
+}
+
+} // namespace
+
+TEST_F(RawVarDataTest, SimpleTest) {
+ ProxyAutoLock lock;
+ EXPECT_TRUE(WriteReadAndCompare(PP_MakeUndefined()));
+ EXPECT_TRUE(WriteReadAndCompare(PP_MakeNull()));
+ EXPECT_TRUE(WriteReadAndCompare(PP_MakeInt32(100)));
+ EXPECT_TRUE(WriteReadAndCompare(PP_MakeBool(PP_TRUE)));
+ EXPECT_TRUE(WriteReadAndCompare(PP_MakeDouble(53.75)));
+ PP_Var object;
+ object.type = PP_VARTYPE_OBJECT;
+ object.value.as_id = 10;
+ EXPECT_TRUE(WriteReadAndCompare(object));
+}
+
+TEST_F(RawVarDataTest, StringTest) {
+ ProxyAutoLock lock;
+ EXPECT_TRUE(WriteReadAndCompare(StringVar::StringToPPVar("")));
+ EXPECT_TRUE(WriteReadAndCompare(StringVar::StringToPPVar("hello world!")));
+}
+
+TEST_F(RawVarDataTest, ArrayBufferTest) {
+ ProxyAutoLock lock;
+ std::string data = "hello world!";
+ PP_Var var = PpapiGlobals::Get()->GetVarTracker()->MakeArrayBufferPPVar(
+ data.size(), data.data());
+ EXPECT_TRUE(WriteReadAndCompare(var));
+ var = PpapiGlobals::Get()->GetVarTracker()->MakeArrayBufferPPVar(0, NULL);
+ EXPECT_TRUE(WriteReadAndCompare(var));
+ // TODO(raymes): add tests for shmem type array buffers.
+}
+
+TEST_F(RawVarDataTest, DictionaryArrayTest) {
+ ProxyAutoLock lock;
+
+ // Empty array.
+ scoped_refptr<ArrayVar> array(new ArrayVar);
+ ScopedPPVar release_array(ScopedPPVar::PassRef(), array->GetPPVar());
+ EXPECT_TRUE(WriteReadAndCompare(array->GetPPVar()));
+
+ size_t index = 0;
+
+ // Array with primitives.
+ array->Set(index++, PP_MakeUndefined());
+ array->Set(index++, PP_MakeNull());
+ array->Set(index++, PP_MakeInt32(100));
+ array->Set(index++, PP_MakeBool(PP_FALSE));
+ array->Set(index++, PP_MakeDouble(0.123));
+ EXPECT_TRUE(WriteReadAndCompare(array->GetPPVar()));
+
+ // Empty dictionary.
+ scoped_refptr<DictionaryVar> dictionary(new DictionaryVar);
+ ScopedPPVar release_dictionary(ScopedPPVar::PassRef(),
+ dictionary->GetPPVar());
+ EXPECT_TRUE(WriteReadAndCompare(dictionary->GetPPVar()));
+
+ // Dictionary with primitives.
+ ScopedPPVar key1(ScopedPPVar::PassRef(), StringVar::StringToPPVar("1"));
+ dictionary->Set(key1.get(), PP_MakeUndefined());
+ ScopedPPVar key2(ScopedPPVar::PassRef(), StringVar::StringToPPVar("2"));
+ dictionary->Set(key2.get(), PP_MakeNull());
+ ScopedPPVar key3(ScopedPPVar::PassRef(), StringVar::StringToPPVar("3"));
+ dictionary->Set(key3.get(), PP_MakeInt32(-100));
+ ScopedPPVar key4(ScopedPPVar::PassRef(), StringVar::StringToPPVar("4"));
+ dictionary->Set(key4.get(), PP_MakeBool(PP_TRUE));
+ ScopedPPVar key5(ScopedPPVar::PassRef(), StringVar::StringToPPVar("5"));
+ dictionary->Set(key5.get(), PP_MakeDouble(-103.52));
+ EXPECT_TRUE(WriteReadAndCompare(dictionary->GetPPVar()));
+
+ // Array with dictionary.
+ array->Set(index++, release_dictionary.get());
+ EXPECT_TRUE(WriteReadAndCompare(array->GetPPVar()));
+
+ // Array with dictionary with array.
+ scoped_refptr<ArrayVar> array2(new ArrayVar);
+ ScopedPPVar release_array2(ScopedPPVar::PassRef(), array2->GetPPVar());
+ array2->Set(0, PP_MakeInt32(100));
+ ScopedPPVar key6(ScopedPPVar::PassRef(), StringVar::StringToPPVar("6"));
+ dictionary->Set(key6.get(), release_array2.get());
+ EXPECT_TRUE(WriteReadAndCompare(array->GetPPVar()));
+
+ // Array <-> dictionary cycle.
+ ScopedPPVar key7(ScopedPPVar::PassRef(), StringVar::StringToPPVar("7"));
+ dictionary->Set(key7.get(), release_array.get());
+ ScopedPPVar result = ScopedPPVar(ScopedPPVar::PassRef(),
+ WriteAndRead(release_dictionary.get()));
+ EXPECT_TRUE(Equals(release_dictionary.get(), result.get()));
+ // Break the cycle.
+ dictionary->Delete(key7.get());
+ DictionaryVar* result_dictionary = DictionaryVar::FromPPVar(result.get());
+ result_dictionary->Delete(key7.get());
+
+ // Array with self references.
+ array->Set(index, release_array.get());
+ result = ScopedPPVar(ScopedPPVar::PassRef(),
+ WriteAndRead(release_array.get()));
+ EXPECT_TRUE(Equals(release_array.get(), result.get()));
+ // Break the self reference.
+ array->Set(index, PP_MakeUndefined());
+ ArrayVar* result_array = ArrayVar::FromPPVar(result.get());
+ result_array->Set(index, PP_MakeUndefined());
+}
+
+} // namespace proxy
+} // namespace ppapi

Powered by Google App Engine
This is Rietveld 408576698