Issue 138863002: Add BUG_PREFIX to codereview.settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 138863002: Add BUG_PREFIX to codereview.settings (Closed)

Created:
6 years, 11 months ago by rmistry

Modified:
6 years, 11 months ago

Reviewers:
borenet

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Add BUG_PREFIX to codereview.settings NOTRY=True NOTREECHECKS=True (SkipBuildbotRuns) BUG=skia:1983 Committed: http://code.google.com/p/skia/source/detail?r=13075

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	codereview.settings	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

borenet

LGTM. There's another codereview.settings in our buildbot source which we should update as well.

6 years, 11 months ago (2014-01-14 21:17:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/rmistry@google.com/138863002/1

6 years, 11 months ago (2014-01-14 21:19:17 UTC) #3

rmistry

6 years, 11 months ago (2014-01-14 21:19:42 UTC) #5

Message was sent while issue was closed.

On 2014/01/14 21:17:52, borenet wrote:
> LGTM.  There's another codereview.settings in our buildbot source which we
> should update as well.

Yes will do.

Expand Messages | Collapse Messages