Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issue 13886014: Remove FeatureDefines.h as it was designed to deal with the variety of build systems for WebKit. (Closed)

Created:
7 years, 8 months ago by lgombos
Modified:
7 years, 8 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove FeatureDefines.h as it was designed to deal with the variety of build systems for WebKit. Values for feature defines are coming from the build system (gyp files) for blink. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148741

Patch Set 1 #

Patch Set 2 : Remove FeatureDefines.h #

Patch Set 3 : Remove FeatureDefines.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -327 lines) Patch
M Source/WebKit/chromium/features.gypi View 1 2 chunks +7 lines, -0 lines 0 comments Download
D Source/wtf/FeatureDefines.h View 1 1 chunk +0 lines, -319 lines 0 comments Download
M Source/wtf/Platform.h View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/wtf/wtf.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
lgombos
More cleanup..
7 years, 8 months ago (2013-04-19 17:28:59 UTC) #1
Peter Beverloo
This is great!! Thanks!
7 years, 8 months ago (2013-04-19 17:30:59 UTC) #2
abarth-chromium
OGM LGTM
7 years, 8 months ago (2013-04-19 18:00:04 UTC) #3
abarth-chromium
OGM -> OMG (I can't even type straight after reading this CL.)
7 years, 8 months ago (2013-04-19 18:00:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/13886014/6001
7 years, 8 months ago (2013-04-19 18:03:30 UTC) #5
eseidel
AZAMGIN!
7 years, 8 months ago (2013-04-19 18:03:52 UTC) #6
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 18:41:45 UTC) #7
Message was sent while issue was closed.
Change committed as 148741

Powered by Google App Engine
This is Rietveld 408576698