Issue 13886014: Remove FeatureDefines.h as it was designed to deal with the variety of build systems for WebKit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13886014: Remove FeatureDefines.h as it was designed to deal with the variety of build systems for WebKit. (Closed)

Created:
7 years, 8 months ago by lgombos

Modified:
7 years, 8 months ago

Reviewers:
Peter Beverloo, eseidel, abarth-chromium

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Remove FeatureDefines.h as it was designed to deal with the variety of build systems for WebKit. Values for feature defines are coming from the build system (gyp files) for blink. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148741

Patch Set 1 #

Patch Set 2 : Remove FeatureDefines.h #

Patch Set 3 : Remove FeatureDefines.h #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -327 lines)			Patch
M	Source/WebKit/chromium/features.gypi	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
D	Source/wtf/FeatureDefines.h	View	1	1 chunk	+0 lines, -319 lines	0 comments	Download
M	Source/wtf/Platform.h	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	Source/wtf/wtf.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

OGM -> OMG (I can't even type straight after reading this CL.)

7 years, 8 months ago (2013-04-19 18:00:21 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/13886014/6001

7 years, 8 months ago (2013-04-19 18:03:30 UTC) #5

Message was sent while issue was closed.

Change committed as 148741

Expand Messages | Collapse Messages