media: Add support for playback of VP8 Alpha video streams

media: Add support for playback of VP8 Alpha video streams

BUG=147355
TEST=VP8 Alpha video streams play
TBR=sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195339

[vignesh, 2013-04-17 00:03:10]

Re-landing VP8 Alpha playback support from this CL:
https://codereview.chromium.org/12263013/


scherkus@, there was an issue with the build because of moving the libvpx
include headers to vpx_video_decoder.h from vpx_video_decoder.cc (this move was
required because you suggested the vpx_codec_ variables to be scoped_ptr (the
deleter required to know about the type)). For some reason, the build failed
while using gcc+gold. This occured on a 32 bit build bot machine but i am also
able to reproduce it in 64 bit (by disabling clang). so, i have changed them
back to be ordinary pointers and have moved the includes back to the .cc files.

+sky for content/browser/ changes
+ccameron for cc/ changes

[scherkus (not reviewing), 2013-04-17 19:15:37]

lgtm w/ nits

https://codereview.chromium.org/13886011/diff/1032/media/filters/vpx_video_de...
File media/filters/vpx_video_decoder.cc (right):

https://codereview.chromium.org/13886011/diff/1032/media/filters/vpx_video_de...
media/filters/vpx_video_decoder.cc:113: context = NULL;
nit: delete context and return NULL instead of setting

https://codereview.chromium.org/13886011/diff/1032/media/filters/vpx_video_de...
media/filters/vpx_video_decoder.cc:350: vpx_image_alpha =
vpx_codec_get_frame(vpx_codec_alpha_,
this fits on one line

https://codereview.chromium.org/13886011/diff/1032/media/filters/vpx_video_de...
media/filters/vpx_video_decoder.cc:379: const struct vpx_image* vpx_image,
nit: C++ doesn't need struct keyword

https://codereview.chromium.org/13886011/diff/1032/media/filters/vpx_video_de...
File media/filters/vpx_video_decoder.h (right):

https://codereview.chromium.org/13886011/diff/1032/media/filters/vpx_video_de...
media/filters/vpx_video_decoder.h:66: void CopyVpxImageTo(const struct
vpx_image* vpx_image,
nit: c++ doesn't need struct keyword

[jamesr, 2013-04-17 19:22:39]

cc/ lgtm

[vignesh, 2013-04-17 20:14:23]

rebased and fixing nits.

https://codereview.chromium.org/13886011/diff/1032/media/filters/vpx_video_de...
File media/filters/vpx_video_decoder.cc (right):

https://codereview.chromium.org/13886011/diff/1032/media/filters/vpx_video_de...
media/filters/vpx_video_decoder.cc:113: context = NULL;
On 2013/04/17 19:15:37, scherkus wrote:
> nit: delete context and return NULL instead of setting

Done.

https://codereview.chromium.org/13886011/diff/1032/media/filters/vpx_video_de...
media/filters/vpx_video_decoder.cc:350: vpx_image_alpha =
vpx_codec_get_frame(vpx_codec_alpha_,
On 2013/04/17 19:15:37, scherkus wrote:
> this fits on one line

Done.

https://codereview.chromium.org/13886011/diff/1032/media/filters/vpx_video_de...
media/filters/vpx_video_decoder.cc:379: const struct vpx_image* vpx_image,
On 2013/04/17 19:15:37, scherkus wrote:
> nit: C++ doesn't need struct keyword

Done.

https://codereview.chromium.org/13886011/diff/1032/media/filters/vpx_video_de...
File media/filters/vpx_video_decoder.h (right):

https://codereview.chromium.org/13886011/diff/1032/media/filters/vpx_video_de...
media/filters/vpx_video_decoder.h:66: void CopyVpxImageTo(const struct
vpx_image* vpx_image,
On 2013/04/17 19:15:37, scherkus wrote:
> nit: c++ doesn't need struct keyword

Done.

[commit-bot: I haz the power, 2013-04-18 17:08:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vigneshv@chromium.org/13886011/13001

[commit-bot: I haz the power, 2013-04-18 18:17:42]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win7_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-18 19:06:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vigneshv@chromium.org/13886011/13001

[commit-bot: I haz the power, 2013-04-18 21:01:36]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-04-19 18:59:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vigneshv@chromium.org/13886011/37002

[commit-bot: I haz the power, 2013-04-19 19:04:52]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_de...

[commit-bot: I haz the power, 2013-04-19 21:42:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vigneshv@chromium.org/13886011/37002

[commit-bot: I haz the power, 2013-04-19 21:44:13]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_de...

[commit-bot: I haz the power, 2013-04-19 22:24:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vigneshv@chromium.org/13886011/37002

[commit-bot: I haz the power, 2013-04-19 23:43:34]

Change committed as 195339