Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py

Issue 1388553002: Fix rebaseline tool to use "git cl land" instead of "git cl dcommit". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 1081 matching lines...) Expand 10 before | Expand all | Expand 10 after
1092 ['python', 'echo', 'rebaseline-test-internal', '--suffixes', 'txt', '--builder', 'MOCK Leopard', '--test', 'fast/dom/prototype-taco.html'], 1092 ['python', 'echo', 'rebaseline-test-internal', '--suffixes', 'txt', '--builder', 'MOCK Leopard', '--test', 'fast/dom/prototype-taco.html'],
1093 ['python', 'echo', 'rebaseline-test-internal', '--suffixes', 'txt', '--builder', 'MOCK SnowLeopard', '--test', 'fast/dom/prototype-taco.html '], 1093 ['python', 'echo', 'rebaseline-test-internal', '--suffixes', 'txt', '--builder', 'MOCK SnowLeopard', '--test', 'fast/dom/prototype-taco.html '],
1094 ], 1094 ],
1095 [ 1095 [
1096 ['python', 'echo', 'optimize-baselines', '--no-modify-scm', '--suffixes', 'txt,png', 'fast/dom/prototype-chocolate.html'], 1096 ['python', 'echo', 'optimize-baselines', '--no-modify-scm', '--suffixes', 'txt,png', 'fast/dom/prototype-chocolate.html'],
1097 ['python', 'echo', 'optimize-baselines', '--no-modify-scm', '--suffixes', 'png', 'fast/dom/prototype-strawberry.html'], 1097 ['python', 'echo', 'optimize-baselines', '--no-modify-scm', '--suffixes', 'png', 'fast/dom/prototype-strawberry.html'],
1098 ['python', 'echo', 'optimize-baselines', '--no-modify-scm', '--suffixes', 'txt', 'fast/dom/prototype-taco.html'], 1098 ['python', 'echo', 'optimize-baselines', '--no-modify-scm', '--suffixes', 'txt', 'fast/dom/prototype-taco.html'],
1099 ], 1099 ],
1100 ['git', 'cl', 'upload', '-f'], 1100 ['git', 'cl', 'upload', '-f'],
1101 ['git', 'pull'], 1101 ['git', 'pull'],
1102 ['git', 'cl', 'dcommit', '-f'], 1102 ['git', 'cl', 'land', '-f', '-v'],
1103 ['git', 'config', 'branch.auto-rebaseline-temporary-branch.rietv eldissue'], 1103 ['git', 'config', 'branch.auto-rebaseline-temporary-branch.rietv eldissue'],
1104 ]) 1104 ])
1105 1105
1106 # The mac ports should both be removed since they're the only ones i n builders._exact_matches. 1106 # The mac ports should both be removed since they're the only ones i n builders._exact_matches.
1107 self.assertEqual(self.tool.filesystem.read_text_file(test_port.path_ to_generic_test_expectations_file()), """ 1107 self.assertEqual(self.tool.filesystem.read_text_file(test_port.path_ to_generic_test_expectations_file()), """
1108 crbug.com/24182 [ Debug ] path/to/norebaseline.html [ Rebaseline ] 1108 crbug.com/24182 [ Debug ] path/to/norebaseline.html [ Rebaseline ]
1109 Bug(foo) [ Linux Win ] fast/dom/prototype-taco.html [ NeedsRebaseline ] 1109 Bug(foo) [ Linux Win ] fast/dom/prototype-taco.html [ NeedsRebaseline ]
1110 crbug.com/24182 [ Linux Win ] fast/dom/prototype-chocolate.html [ NeedsRebaselin e ] 1110 crbug.com/24182 [ Linux Win ] fast/dom/prototype-chocolate.html [ NeedsRebaselin e ]
1111 crbug.com/24182 path/to/not-cycled-through-bots.html [ NeedsRebaseline ] 1111 crbug.com/24182 path/to/not-cycled-through-bots.html [ NeedsRebaseline ]
1112 crbug.com/24182 path/to/locally-changed-lined.html [ NeedsRebaseline ] 1112 crbug.com/24182 path/to/locally-changed-lined.html [ NeedsRebaseline ]
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
1219 "MOCK Leopard": {"port_name": "test-mac-leopard", "specifiers": set(["mock-specifier"])}, 1219 "MOCK Leopard": {"port_name": "test-mac-leopard", "specifiers": set(["mock-specifier"])},
1220 "MOCK SnowLeopard": {"port_name": "test-mac-snowleopard", "speci fiers": set(["mock-specifier"])}, 1220 "MOCK SnowLeopard": {"port_name": "test-mac-snowleopard", "speci fiers": set(["mock-specifier"])},
1221 } 1221 }
1222 1222
1223 self.command.tree_status = lambda: 'open' 1223 self.command.tree_status = lambda: 'open'
1224 self.command.execute(MockOptions(optimize=True, verbose=False, resul ts_directory=False), [], self.tool) 1224 self.command.execute(MockOptions(optimize=True, verbose=False, resul ts_directory=False), [], self.tool)
1225 self.assertEqual(self.tool.executive.calls, [ 1225 self.assertEqual(self.tool.executive.calls, [
1226 [['python', 'echo', 'optimize-baselines', '--no-modify-scm', '-- suffixes', '', 'fast/dom/prototype-taco.html']], 1226 [['python', 'echo', 'optimize-baselines', '--no-modify-scm', '-- suffixes', '', 'fast/dom/prototype-taco.html']],
1227 ['git', 'cl', 'upload', '-f'], 1227 ['git', 'cl', 'upload', '-f'],
1228 ['git', 'pull'], 1228 ['git', 'pull'],
1229 ['git', 'cl', 'dcommit', '-f'], 1229 ['git', 'cl', 'land', '-f', '-v'],
1230 ['git', 'config', 'branch.auto-rebaseline-temporary-branch.rietv eldissue'], 1230 ['git', 'config', 'branch.auto-rebaseline-temporary-branch.rietv eldissue'],
1231 ]) 1231 ])
1232 1232
1233 # The mac ports should both be removed since they're the only ones i n builders._exact_matches. 1233 # The mac ports should both be removed since they're the only ones i n builders._exact_matches.
1234 self.assertEqual(self.tool.filesystem.read_text_file(test_port.path_ to_generic_test_expectations_file()), """ 1234 self.assertEqual(self.tool.filesystem.read_text_file(test_port.path_ to_generic_test_expectations_file()), """
1235 Bug(foo) [ Linux Win ] fast/dom/prototype-taco.html [ NeedsRebaseline ] 1235 Bug(foo) [ Linux Win ] fast/dom/prototype-taco.html [ NeedsRebaseline ]
1236 """) 1236 """)
1237 finally: 1237 finally:
1238 builders._exact_matches = old_exact_matches 1238 builders._exact_matches = old_exact_matches
1239 1239
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
1280 "MOCK Win": {"port_name": "test-win-win7", "specifiers": set(["m ock-specifier"])}, 1280 "MOCK Win": {"port_name": "test-win-win7", "specifiers": set(["m ock-specifier"])},
1281 } 1281 }
1282 1282
1283 self.command.tree_status = lambda: 'open' 1283 self.command.tree_status = lambda: 'open'
1284 webkitpy.tool.commands.rebaseline._get_branch_name_or_ref = lambda x : 'auto-rebaseline-temporary-branch' 1284 webkitpy.tool.commands.rebaseline._get_branch_name_or_ref = lambda x : 'auto-rebaseline-temporary-branch'
1285 self.command.execute(MockOptions(optimize=True, verbose=False, resul ts_directory=False), [], self.tool) 1285 self.command.execute(MockOptions(optimize=True, verbose=False, resul ts_directory=False), [], self.tool)
1286 self.assertEqual(self.tool.executive.calls, [ 1286 self.assertEqual(self.tool.executive.calls, [
1287 [['python', 'echo', 'optimize-baselines', '--no-modify-scm', '-- suffixes', '', 'fast/dom/prototype-taco.html']], 1287 [['python', 'echo', 'optimize-baselines', '--no-modify-scm', '-- suffixes', '', 'fast/dom/prototype-taco.html']],
1288 ['git', 'cl', 'upload', '-f'], 1288 ['git', 'cl', 'upload', '-f'],
1289 ['git', 'pull'], 1289 ['git', 'pull'],
1290 ['git', 'cl', 'dcommit', '-f'], 1290 ['git', 'cl', 'land', '-f', '-v'],
1291 ['git', 'config', 'branch.auto-rebaseline-alt-temporary-branch.r ietveldissue'], 1291 ['git', 'config', 'branch.auto-rebaseline-alt-temporary-branch.r ietveldissue'],
1292 ]) 1292 ])
1293 1293
1294 self.assertEqual(self.tool.filesystem.read_text_file(test_port.path_ to_generic_test_expectations_file()), """ 1294 self.assertEqual(self.tool.filesystem.read_text_file(test_port.path_ to_generic_test_expectations_file()), """
1295 Bug(foo) [ Linux Mac XP ] fast/dom/prototype-taco.html [ NeedsRebaseline ] 1295 Bug(foo) [ Linux Mac XP ] fast/dom/prototype-taco.html [ NeedsRebaseline ]
1296 """) 1296 """)
1297 finally: 1297 finally:
1298 builders._exact_matches = old_exact_matches 1298 builders._exact_matches = old_exact_matches
1299 1299
1300 def test_execute_stuck_on_alternate_rebaseline_branch(self): 1300 def test_execute_stuck_on_alternate_rebaseline_branch(self):
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
1340 "MOCK Win": {"port_name": "test-win-win7", "specifiers": set(["m ock-specifier"])}, 1340 "MOCK Win": {"port_name": "test-win-win7", "specifiers": set(["m ock-specifier"])},
1341 } 1341 }
1342 1342
1343 self.command.tree_status = lambda: 'open' 1343 self.command.tree_status = lambda: 'open'
1344 webkitpy.tool.commands.rebaseline._get_branch_name_or_ref = lambda x : 'auto-rebaseline-alt-temporary-branch' 1344 webkitpy.tool.commands.rebaseline._get_branch_name_or_ref = lambda x : 'auto-rebaseline-alt-temporary-branch'
1345 self.command.execute(MockOptions(optimize=True, verbose=False, resul ts_directory=False), [], self.tool) 1345 self.command.execute(MockOptions(optimize=True, verbose=False, resul ts_directory=False), [], self.tool)
1346 self.assertEqual(self.tool.executive.calls, [ 1346 self.assertEqual(self.tool.executive.calls, [
1347 [['python', 'echo', 'optimize-baselines', '--no-modify-scm', '-- suffixes', '', 'fast/dom/prototype-taco.html']], 1347 [['python', 'echo', 'optimize-baselines', '--no-modify-scm', '-- suffixes', '', 'fast/dom/prototype-taco.html']],
1348 ['git', 'cl', 'upload', '-f'], 1348 ['git', 'cl', 'upload', '-f'],
1349 ['git', 'pull'], 1349 ['git', 'pull'],
1350 ['git', 'cl', 'dcommit', '-f'], 1350 ['git', 'cl', 'land', '-f', '-v'],
1351 ['git', 'config', 'branch.auto-rebaseline-temporary-branch.rietv eldissue'], 1351 ['git', 'config', 'branch.auto-rebaseline-temporary-branch.rietv eldissue'],
1352 ]) 1352 ])
1353 1353
1354 self.assertEqual(self.tool.filesystem.read_text_file(test_port.path_ to_generic_test_expectations_file()), """ 1354 self.assertEqual(self.tool.filesystem.read_text_file(test_port.path_ to_generic_test_expectations_file()), """
1355 Bug(foo) [ Linux Mac XP ] fast/dom/prototype-taco.html [ NeedsRebaseline ] 1355 Bug(foo) [ Linux Mac XP ] fast/dom/prototype-taco.html [ NeedsRebaseline ]
1356 """) 1356 """)
1357 finally: 1357 finally:
1358 builders._exact_matches = old_exact_matches 1358 builders._exact_matches = old_exact_matches
1359 1359
1360 1360
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
1399 oc.capture_output() 1399 oc.capture_output()
1400 self.command._do_one_rebaseline() 1400 self.command._do_one_rebaseline()
1401 out, _, _ = oc.restore_output() 1401 out, _, _ = oc.restore_output()
1402 1402
1403 self.assertEqual(out, 'MOCK STDOUT\n') 1403 self.assertEqual(out, 'MOCK STDOUT\n')
1404 self.assertEqual(self.tool.executive.calls, [ 1404 self.assertEqual(self.tool.executive.calls, [
1405 ['git', 'pull'], 1405 ['git', 'pull'],
1406 ['/mock-checkout/third_party/WebKit/Tools/Scripts/webkit-patch', 'au to-rebaseline', '--verbose'], 1406 ['/mock-checkout/third_party/WebKit/Tools/Scripts/webkit-patch', 'au to-rebaseline', '--verbose'],
1407 ]) 1407 ])
1408 self.assertEqual(self._logs, ['MOCK STDOUT']) 1408 self.assertEqual(self._logs, ['MOCK STDOUT'])
OLDNEW
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698