Issue 1388543008: 1. Write the backing data array of a GrowableObjectArray as a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1388543008: 1. Write the backing data array of a GrowableObjectArray as a reference (Closed)

Created:
5 years, 2 months ago by siva

Modified:
5 years, 2 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

1. Write the backing data array of a GrowableObjectArray as a reference 2. Cleanup and refactor WriteObjectRef and WriteObjectInlined and pass as_reference as a parameter to the WriteTo function to allow respective types to deal with it. 3. Added a as_reference parameter to the ReadFrom functions (currently the parameter is not used but the next round of changes will cleanup ReadObjectRef and ReadObjectInlined similarly). R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/02c702bf929cbcb3b65ea07ecb48e1c56b227d3d

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+472 lines, -412 lines)			Patch
M	runtime/vm/dart_api_message.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1 2 3	6 chunks	+12 lines, -6 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View	1 2 3	130 chunks	+317 lines, -174 lines	0 comments	Download
M	runtime/vm/snapshot.h	View	1 2	3 chunks	+15 lines, -7 lines	0 comments	Download
M	runtime/vm/snapshot.cc	View	1 2 3	18 chunks	+125 lines, -222 lines	0 comments	Download
M	tests/isolate/isolate.status	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

siva

5 years, 2 months ago (2015-10-12 19:46:05 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
02c702bf929cbcb3b65ea07ecb48e1c56b227d3d (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1388543008: 1. Write the backing data array of a GrowableObjectArray as a reference (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix-crashes #

Patch Set 3 : self-review-comments #

Patch Set 4 : sync-to-tot #

Messages