Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1310)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1388543005: Validate text blob runs after SkTextBlob construction. (Closed)

Created:
5 years, 2 months ago by f(malita)
Modified:
5 years, 2 months ago
Reviewers:
bungeman-skia, reed1, krasin
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Validate text blob runs after SkTextBlob construction. This avoids tripping CFI when casting uninitialized SkTextBlob ptrs. BUG=chromium:538754 R=bungeman@google.com,reed@google.com,krasin@google.com Committed: https://skia.googlesource.com/skia/+/92d976c3ad06d4a398d7bf95d2060e40154c39d7

Patch Set 1 #

Patch Set 2 : now actually tested #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M src/core/SkTextBlob.cpp View 1 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
f(malita)
5 years, 2 months ago (2015-10-05 17:51:05 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388543005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388543005/1
5 years, 2 months ago (2015-10-05 17:51:37 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/3477)
5 years, 2 months ago (2015-10-05 17:53:35 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388543005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388543005/20001
5 years, 2 months ago (2015-10-05 18:01:20 UTC) #8
krasin
LGTM
5 years, 2 months ago (2015-10-05 18:01:29 UTC) #9
bungeman-skia
lgtm
5 years, 2 months ago (2015-10-05 18:03:56 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-05 18:07:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388543005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388543005/20001
5 years, 2 months ago (2015-10-05 18:09:15 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 18:10:01 UTC) #15
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/92d976c3ad06d4a398d7bf95d2060e40154c39d7

Powered by Google App Engine
This is Rietveld 408576698