dart2js: add support for configuration-specific imports.

dart2js: add support for configuration-specific imports.

R=johnniwinther@google.com, rnystrom@google.com

Committed: https://github.com/dart-lang/sdk/commit/64edfaf21af3153f32e1229dd97c9b3d40cbfb2b
Reverted: https://github.com/dart-lang/sdk/commit/f38b810d334900317ee6c919b45ebd0c673fdb02

Committed: https://github.com/dart-lang/sdk/commit/af4983c6b26875568516bbdb7f7a669a20ce52fa

[Bob Nystrom, 2015-10-06 23:46:34]

rnystrom@google.com changed reviewers:
+ rnystrom@google.com

[Bob Nystrom, 2015-10-06 23:46:35]

Two nits, but otherwise this looks fantastic. LGTM!

https://codereview.chromium.org/1388523002/diff/1/pkg/compiler/lib/src/tree/n...
File pkg/compiler/lib/src/tree/nodes.dart (right):

https://codereview.chromium.org/1388523002/diff/1/pkg/compiler/lib/src/tree/n...
pkg/compiler/lib/src/tree/nodes.dart:1029: // TODO: this could a
DottedIdentifier.
Nit: "be"

https://codereview.chromium.org/1388523002/diff/1/pkg/compiler/lib/src/tree/n...
pkg/compiler/lib/src/tree/nodes.dart:2057: *       if other.condition
'gee.dart';
These conditions should be parenthesized.

[floitsch, 2015-10-12 19:26:33]

floitsch@google.com changed reviewers:
+ johnniwinther@google.com

[floitsch, 2015-10-12 19:26:33]

floitsch@google.com changed required reviewers:
+ johnniwinther@google.com

[floitsch, 2015-10-12 19:26:34]

https://codereview.chromium.org/1388523002/diff/1/pkg/compiler/lib/src/tree/n...
File pkg/compiler/lib/src/tree/nodes.dart (right):

https://codereview.chromium.org/1388523002/diff/1/pkg/compiler/lib/src/tree/n...
pkg/compiler/lib/src/tree/nodes.dart:1029: // TODO: this could a
DottedIdentifier.
On 2015/10/06 23:46:35, Bob Nystrom wrote:
> Nit: "be"

Done.

https://codereview.chromium.org/1388523002/diff/1/pkg/compiler/lib/src/tree/n...
pkg/compiler/lib/src/tree/nodes.dart:2057: *       if other.condition
'gee.dart';
On 2015/10/06 23:46:35, Bob Nystrom wrote:
> These conditions should be parenthesized.

Done.

[Johnni Winther, 2015-10-13 08:44:29]

LGTM

Should the feature be guarded by a flag?

https://codereview.chromium.org/1388523002/diff/40001/pkg/compiler/lib/src/pa...
File pkg/compiler/lib/src/parser/parser.dart (right):

https://codereview.chromium.org/1388523002/diff/40001/pkg/compiler/lib/src/pa...
pkg/compiler/lib/src/parser/parser.dart:221: /// export uri combinator* ';'
Update comment.

https://codereview.chromium.org/1388523002/diff/40001/pkg/compiler/lib/src/tr...
File pkg/compiler/lib/src/tree/nodes.dart (right):

https://codereview.chromium.org/1388523002/diff/40001/pkg/compiler/lib/src/tr...
pkg/compiler/lib/src/tree/nodes.dart:38: R visitIf(If node) =>
visitStatement(node);dotteDependency(node);
Remove `dotteDependency(node);`

[Bob Nystrom, 2015-10-13 16:07:56]

On 2015/10/13 08:44:29, Johnni Winther wrote:
> LGTM
> 
> Should the feature be guarded by a flag?

Yes. Let's do "conditional-directives" unless someone has a better name.

Florian, since you're working on this, do you mind filing tracking bugs similar
to: https://github.com/dart-lang/sdk/issues/23770

– bob

[floitsch, 2015-10-13 20:59:41]

Patchset #4 (id:60001) has been deleted

[floitsch, 2015-10-13 21:01:44]

PTAL at the latest patch set. (the flag).

https://codereview.chromium.org/1388523002/diff/40001/pkg/compiler/lib/src/pa...
File pkg/compiler/lib/src/parser/parser.dart (right):

https://codereview.chromium.org/1388523002/diff/40001/pkg/compiler/lib/src/pa...
pkg/compiler/lib/src/parser/parser.dart:221: /// export uri combinator* ';'
On 2015/10/13 08:44:29, Johnni Winther wrote:
> Update comment.

Done.

https://codereview.chromium.org/1388523002/diff/40001/pkg/compiler/lib/src/tr...
File pkg/compiler/lib/src/tree/nodes.dart (right):

https://codereview.chromium.org/1388523002/diff/40001/pkg/compiler/lib/src/tr...
pkg/compiler/lib/src/tree/nodes.dart:38: R visitIf(If node) =>
visitStatement(node);dotteDependency(node);
On 2015/10/13 08:44:29, Johnni Winther wrote:
> Remove `dotteDependency(node);`

thanks!

https://codereview.chromium.org/1388523002/diff/80001/pkg/compiler/lib/src/pa...
File pkg/compiler/lib/src/parser/class_element_parser.dart (right):

https://codereview.chromium.org/1388523002/diff/80001/pkg/compiler/lib/src/pa...
pkg/compiler/lib/src/parser/class_element_parser.dart:17: : super(listener,
enableConditionalDirectives: false);
It was hard to get the actual flag to this parser.
Since it only deals with classes, I just forced the argument to 'false'.
If that doesn't look ok, please speak up.

[Johnni Winther, 2015-10-14 07:21:52]

lgtm

https://codereview.chromium.org/1388523002/diff/80001/pkg/compiler/lib/src/pa...
File pkg/compiler/lib/src/parser/class_element_parser.dart (right):

https://codereview.chromium.org/1388523002/diff/80001/pkg/compiler/lib/src/pa...
pkg/compiler/lib/src/parser/class_element_parser.dart:17: : super(listener,
enableConditionalDirectives: false);
On 2015/10/13 21:01:44, floitsch wrote:
> It was hard to get the actual flag to this parser.
> Since it only deals with classes, I just forced the argument to 'false'.
> If that doesn't look ok, please speak up.

The plan is to have a ParsingOptions object that is always provided.

https://codereview.chromium.org/1388523002/diff/80001/pkg/compiler/lib/src/pa...
File pkg/compiler/lib/src/parser/parser_task.dart (right):

https://codereview.chromium.org/1388523002/diff/80001/pkg/compiler/lib/src/pa...
pkg/compiler/lib/src/parser/parser_task.dart:44: print("parser:
$_enableConditionalDirectives");
Remove debug code.

[floitsch, 2015-12-10 19:38:45]

https://codereview.chromium.org/1388523002/diff/80001/pkg/compiler/lib/src/pa...
File pkg/compiler/lib/src/parser/parser_task.dart (right):

https://codereview.chromium.org/1388523002/diff/80001/pkg/compiler/lib/src/pa...
pkg/compiler/lib/src/parser/parser_task.dart:44: print("parser:
$_enableConditionalDirectives");
On 2015/10/14 07:21:52, Johnni Winther wrote:
> Remove debug code.

Done.

[floitsch, 2015-12-10 23:25:06]

Description was changed from

==========
dart2js: add support for configuration-specific imports.
==========

to

==========
dart2js: add support for configuration-specific imports.

R=johnniwinther@google.com, rnystrom@google.com

Committed:
https://github.com/dart-lang/sdk/commit/64edfaf21af3153f32e1229dd97c9b3d40cbfb2b
==========

[floitsch, 2015-12-10 23:25:08]

Committed patchset #5 (id:100001) manually as
64edfaf21af3153f32e1229dd97c9b3d40cbfb2b (presubmit successful).

[floitsch, 2015-12-11 04:31:34]

Description was changed from

==========
dart2js: add support for configuration-specific imports.

R=johnniwinther@google.com, rnystrom@google.com

Committed:
https://github.com/dart-lang/sdk/commit/64edfaf21af3153f32e1229dd97c9b3d40cbfb2b
==========

to

==========
dart2js: add support for configuration-specific imports.

R=johnniwinther@google.com, rnystrom@google.com

Committed:
https://github.com/dart-lang/sdk/commit/64edfaf21af3153f32e1229dd97c9b3d40cbfb2b
Reverted:
https://github.com/dart-lang/sdk/commit/f38b810d334900317ee6c919b45ebd0c673fdb02
==========

[floitsch, 2015-12-11 05:17:19]

Description was changed from

==========
dart2js: add support for configuration-specific imports.

R=johnniwinther@google.com, rnystrom@google.com

Committed:
https://github.com/dart-lang/sdk/commit/64edfaf21af3153f32e1229dd97c9b3d40cbfb2b
Reverted:
https://github.com/dart-lang/sdk/commit/f38b810d334900317ee6c919b45ebd0c673fdb02
==========

to

==========
dart2js: add support for configuration-specific imports.

R=johnniwinther@google.com, rnystrom@google.com

Committed:
https://github.com/dart-lang/sdk/commit/64edfaf21af3153f32e1229dd97c9b3d40cbfb2b
Reverted:
https://github.com/dart-lang/sdk/commit/f38b810d334900317ee6c919b45ebd0c673fdb02

Committed:
https://github.com/dart-lang/sdk/commit/af4983c6b26875568516bbdb7f7a669a20ce52fa
==========

[floitsch, 2015-12-11 05:17:20]

Committed patchset #7 (id:140001) manually as
af4983c6b26875568516bbdb7f7a669a20ce52fa (presubmit successful).