Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1697)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/notifications/notification_database_data.proto

Issue 1388483002: Implement the Notification `timestamp` property (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase + layout tests Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/notifications/platform_notification_service.html ('k') | content/browser/notifications/notification_database_data_conversions.cc » ('j') | content/child/notifications/notification_data_conversions_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/notifications/notification_database_data.proto
diff --git a/content/browser/notifications/notification_database_data.proto b/content/browser/notifications/notification_database_data.proto
index 3047d2b4356e28c5b79410ad156eb755fd97687b..17620782d9d596c20b85a8b751e8d880f52061ce 100644
--- a/content/browser/notifications/notification_database_data.proto
+++ b/content/browser/notifications/notification_database_data.proto
@@ -29,7 +29,7 @@ message NotificationDatabaseDataProto {
// Actual data payload of the notification. This message is the protocol
// buffer meant to serialize the content::PlatformNotificationData structure.
//
- // Next tag: 12
+ // Next tag: 13
message NotificationData {
enum Direction {
LEFT_TO_RIGHT = 0;
@@ -44,6 +44,7 @@ message NotificationDatabaseDataProto {
optional string tag = 5;
optional string icon = 6;
repeated int32 vibration_pattern = 9 [packed=true];
+ optional int64 timestamp = 12;
optional bool silent = 7;
optional bool require_interaction = 11;
optional bytes data = 8;
« no previous file with comments | « chrome/test/data/notifications/platform_notification_service.html ('k') | content/browser/notifications/notification_database_data_conversions.cc » ('j') | content/child/notifications/notification_data_conversions_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698