Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Unified Diff: content/browser/notifications/notification_database_data.proto

Issue 1388483002: Implement the Notification `timestamp` property (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/notifications/notification_database_data.proto
diff --git a/content/browser/notifications/notification_database_data.proto b/content/browser/notifications/notification_database_data.proto
index 3047d2b4356e28c5b79410ad156eb755fd97687b..03d8172cf87b50aaa4e1cf463c04ee77f7339949 100644
--- a/content/browser/notifications/notification_database_data.proto
+++ b/content/browser/notifications/notification_database_data.proto
@@ -29,7 +29,7 @@ message NotificationDatabaseDataProto {
// Actual data payload of the notification. This message is the protocol
// buffer meant to serialize the content::PlatformNotificationData structure.
//
- // Next tag: 12
+ // Next tag: 13
message NotificationData {
enum Direction {
LEFT_TO_RIGHT = 0;
@@ -44,6 +44,7 @@ message NotificationDatabaseDataProto {
optional string tag = 5;
optional string icon = 6;
repeated int32 vibration_pattern = 9 [packed=true];
+ optional double timestamp = 12;
johnme 2015/10/20 17:12:21 Why not an int64, to match the base::Time in Platf
Peter Beverloo 2016/01/28 17:18:29 Done.
optional bool silent = 7;
optional bool require_interaction = 11;
optional bytes data = 8;

Powered by Google App Engine
This is Rietveld 408576698