chrome/browser/notifications/notification_ui_manager_android.cc - Issue 1388483002: Implement the Notification `timestamp` property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_ui_manager_android.cc

Issue 1388483002: Implement the Notification `timestamp` property (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/notifications/notification_ui_manager_android.cc

diff --git a/chrome/browser/notifications/notification_ui_manager_android.cc b/chrome/browser/notifications/notification_ui_manager_android.cc

index 23c75c444a6177de1324d499992b4673da69e040..a281421cab737fbfa721623728c12541bd848f6c 100644

--- a/chrome/browser/notifications/notification_ui_manager_android.cc

+++ b/chrome/browser/notifications/notification_ui_manager_android.cc

@@ -152,6 +152,7 @@ void NotificationUIManagerAndroid::Add(const Notification& notification,

body.obj(),

icon.obj(),

vibration_pattern.obj(),

+ notification.timestamp().ToJavaTime(),

johnme 2015/10/20 17:12:21 FYI ToJavaTime can underflow for times in between

Peter Beverloo 2016/01/28 17:18:29 Acknowledged.

notification.silent(),

action_titles.obj());