content/browser/notifications/notification_database_data_conversions.cc - Issue 1388483002: Implement the Notification `timestamp` property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/notifications/notification_database_data_conversions.cc

Issue 1388483002: Implement the Notification `timestamp` property (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/notifications/notification_database_data.proto ('k') | content/browser/notifications/notification_database_data_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/notifications/notification_database_data_conversions.cc

diff --git a/content/browser/notifications/notification_database_data_conversions.cc b/content/browser/notifications/notification_database_data_conversions.cc

index cf19704f9dc20e209022b60d5aa26a633dca5bd5..8621fc13bf7e634d2c03b49f8675de3fb21e4b03 100644

--- a/content/browser/notifications/notification_database_data_conversions.cc

+++ b/content/browser/notifications/notification_database_data_conversions.cc

@@ -8,6 +8,7 @@

#include "base/logging.h"

#include "base/strings/utf_string_conversions.h"

+#include "base/time/time.h"

#include "content/browser/notifications/notification_database_data.pb.h"

#include "content/public/browser/notification_database_data.h"

@@ -56,6 +57,8 @@ bool DeserializeNotificationDatabaseData(const std::string& input,

payload.vibration_pattern().begin(), payload.vibration_pattern().end());

}

+ notification_data->timestamp =

+ base::Time::FromInternalValue(payload.timestamp());

notification_data->silent = payload.silent();

notification_data->require_interaction = payload.require_interaction();

@@ -108,6 +111,7 @@ bool SerializeNotificationDatabaseData(const NotificationDatabaseData& input,

for (size_t i = 0; i < notification_data.vibration_pattern.size(); ++i)

payload->add_vibration_pattern(notification_data.vibration_pattern[i]);

+ payload->set_timestamp(notification_data.timestamp.ToInternalValue());

payload->set_silent(notification_data.silent);

payload->set_require_interaction(notification_data.require_interaction);